Adds color, font size, text direction and text styles to the accessibility tree.

Initial support for foreground / background color, text direction, font size, bold, italics, underline and strikethrough. Platform specific code will follow in another CL.

BUG=347869
R=dmazzoni

Committed: https://crrev.com/d891c769a08605f84da08c8a4d9d9602d2426c48
Cr-Commit-Position: refs/heads/master@{#329665}

[dmazzoni, 2015-05-12 18:34:48]

lgtm

https://codereview.chromium.org/1130733006/diff/60001/content/renderer/access...
File content/renderer/accessibility/blink_ax_enum_conversion.cc (right):

https://codereview.chromium.org/1130733006/diff/60001/content/renderer/access...
content/renderer/accessibility/blink_ax_enum_conversion.cc:421: return
ui::AX_TEXT_STYLE_UNDERLINE;
I just realized, these shouldn't be mutually exclusive, they should be additive.
It's possible to be bold, italic, underline, and linethrough simultaneously.

Can you patch this in Blink?

[chromium-reviews, 2015-05-12 18:37:52]

In Blink it's fine. I use the "or" operator to combine a set of bit flags.
I just need to fix this conversion method. Too much copy/pasting without 
thinking.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-05-12 18:53:42]

Oh, good. lgtm.


On Tue, May 12, 2015 at 11:37 AM, 'Nektarios Paisios' via Chromium-reviews <
chromium-reviews@chromium.org> wrote:

> In Blink it's fine. I use the "or" operator to combine a set of bit flags.
> I just need to fix this conversion method. Too much copy/pasting without
> thinking.
>
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sgurun-gerrit only, 2015-05-12 19:21:00]

On 2015/05/12 18:34:48, dmazzoni wrote:
> lgtm
> 
>
https://codereview.chromium.org/1130733006/diff/60001/content/renderer/access...
> File content/renderer/accessibility/blink_ax_enum_conversion.cc (right):
> 
>
https://codereview.chromium.org/1130733006/diff/60001/content/renderer/access...
> content/renderer/accessibility/blink_ax_enum_conversion.cc:421: return
> ui::AX_TEXT_STYLE_UNDERLINE;
> I just realized, these shouldn't be mutually exclusive, they should be
additive.
> It's possible to be bold, italic, underline, and linethrough simultaneously.
> 
> Can you patch this in Blink?

this fails compiling android since ui::AX_ATTR_COLOR_VALUE_BLUE, etc are still
in use.

[sgurun-gerrit only, 2015-05-12 20:11:35]

On 2015/05/12 19:21:00, sgurun wrote:
> On 2015/05/12 18:34:48, dmazzoni wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/1130733006/diff/60001/content/renderer/access...
> > File content/renderer/accessibility/blink_ax_enum_conversion.cc (right):
> > 
> >
>
https://codereview.chromium.org/1130733006/diff/60001/content/renderer/access...
> > content/renderer/accessibility/blink_ax_enum_conversion.cc:421: return
> > ui::AX_TEXT_STYLE_UNDERLINE;
> > I just realized, these shouldn't be mutually exclusive, they should be
> additive.
> > It's possible to be bold, italic, underline, and linethrough simultaneously.
> > 
> > Can you patch this in Blink?
> 
> this fails compiling android since ui::AX_ATTR_COLOR_VALUE_BLUE, etc are still
> in use.

[sgurun-gerrit only, 2015-05-12 20:11:58]

sgurun@chromium.org changed reviewers:
+ sgurun@chromium.org

[sgurun-gerrit only, 2015-05-12 20:11:58]

2 more issues.

https://codereview.chromium.org/1130733006/diff/60001/content/renderer/access...
File content/renderer/accessibility/blink_ax_enum_conversion.cc (right):

https://codereview.chromium.org/1130733006/diff/60001/content/renderer/access...
content/renderer/accessibility/blink_ax_enum_conversion.cc:414: case
blink::WebAXTextStyleNone:
no member named 'WebAXTextDirectionUnknown' in namespace 'blink'

https://codereview.chromium.org/1130733006/diff/60001/ui/accessibility/ax_nod...
File ui/accessibility/ax_node_data.cc (right):

https://codereview.chromium.org/1130733006/diff/60001/ui/accessibility/ax_nod...
ui/accessibility/ax_node_data.cc:371: }
../../ui/accessibility/ax_node_data.cc:130:13: error: enumeration values
'AX_ATTR_COLOR_VALUE' and 'AX_ATTR_TEXT_STYLE' not handled in switch
[-Werror,-Wswitch]
    switch (int_attributes[i].first) {

[chromium-reviews, 2015-05-12 20:34:01]

I know, I fixed that. Forgot to upload.
Will do now.


On 5/12/2015 3:21 PM, sgurun@chromium.org wrote:
> On 2015/05/12 18:34:48, dmazzoni wrote:
>> lgtm
>
>
>
https://codereview.chromium.org/1130733006/diff/60001/content/renderer/access...

>
>> File content/renderer/accessibility/blink_ax_enum_conversion.cc (right):
>
>
>
https://codereview.chromium.org/1130733006/diff/60001/content/renderer/access...

>
>> content/renderer/accessibility/blink_ax_enum_conversion.cc:421: return
>> ui::AX_TEXT_STYLE_UNDERLINE;
>> I just realized, these shouldn't be mutually exclusive, they should be
> additive.
>> It's possible to be bold, italic, underline, and linethrough 
>> simultaneously.
>
>> Can you patch this in Blink?
>
> this fails compiling android since ui::AX_ATTR_COLOR_VALUE_BLUE, etc 
> are still
> in use.
>
> https://codereview.chromium.org/1130733006/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nektarios, 2015-05-13 04:16:24]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-05-13 04:16:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1130733006/#ps160001
(title: "Fixed unit test.")

[commit-bot: I haz the power, 2015-05-13 04:16:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130733006/160001

[commit-bot: I haz the power, 2015-05-13 04:40:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-13 04:40:36]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[nektarios, 2015-05-13 16:22:54]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-05-13 16:22:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1130733006/#ps180001
(title: "Fixed colorwells on the Mac.")

[commit-bot: I haz the power, 2015-05-13 16:23:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130733006/180001

[commit-bot: I haz the power, 2015-05-13 17:28:20]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-05-13 17:29:15]

Patchset 10 (id:??) landed as
https://crrev.com/d891c769a08605f84da08c8a4d9d9602d2426c48
Cr-Commit-Position: refs/heads/master@{#329665}