content/browser/accessibility/browser_accessibility_android.cc - Issue 1130733006: Adds color, font size, text direction and text styles to the accessibility tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 1130733006: Adds color, font size, text direction and text styles to the accessibility tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt at exposing style info to the native APIs. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility.cc ('k') | content/browser/accessibility/browser_accessibility_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc

index dcb723fc5e6b15fb0cf5761986f5aecaf6847c9e..a9e10ab7da7fe379ba8235704308c316a6bb6aa3 100644

--- a/content/browser/accessibility/browser_accessibility_android.cc

+++ b/content/browser/accessibility/browser_accessibility_android.cc

@@ -351,9 +351,10 @@ base::string16 BrowserAccessibilityAndroid::GetText() const {

// For color wells, the color is stored in separate attributes.

// Perhaps we could return color names in the future?

if (GetRole() == ui::AX_ROLE_COLOR_WELL) {

- int red = GetIntAttribute(ui::AX_ATTR_COLOR_VALUE_RED);

- int green = GetIntAttribute(ui::AX_ATTR_COLOR_VALUE_GREEN);

- int blue = GetIntAttribute(ui::AX_ATTR_COLOR_VALUE_BLUE);

+ int color = GetIntAttribute(ui::AX_ATTR_COLOR_VALUE);

+ int red = (color >> 16) & 0xFF;

+ int green = (color >> 8) & 0xFF;

+ int blue = color & 0xFF;

return base::UTF8ToUTF16(

base::StringPrintf("#%02X%02X%02X", red, green, blue));

}