content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 1130733006: Adds color, font size, text direction and text styles to the accessibility tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 1130733006: Adds color, font size, text direction and text styles to the accessibility tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt at exposing style info to the native APIs. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_android.cc ('k') | content/browser/accessibility/browser_accessibility_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index d333ae1d748999b0776c392e4dbca52ce15bf8bc..b3c706b7d5bebfa8a0f3487bc215cac69fb0e4c6 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -970,15 +970,14 @@ NSDictionary* attributeToMethodNameMap = nil;

return [NSNumber numberWithFloat:floatValue];

}

} else if ([role isEqualToString:NSAccessibilityColorWellRole]) {

- int r = browserAccessibility_->GetIntAttribute(

- ui::AX_ATTR_COLOR_VALUE_RED);

- int g = browserAccessibility_->GetIntAttribute(

- ui::AX_ATTR_COLOR_VALUE_GREEN);

- int b = browserAccessibility_->GetIntAttribute(

- ui::AX_ATTR_COLOR_VALUE_BLUE);

+ int color = browserAccessibility_->GetIntAttribute(

+ ui::AX_ATTR_COLOR_VALUE);

+ int red = (color >> 16) & 0xFF;

+ int green = (color >> 8) & 0xFF;

+ int blue = color & 0xFF;

// This string matches the one returned by a native Mac color well.

return [NSString stringWithFormat:@"rgb %7.5f %7.5f %7.5f 1",

- r / 255., g / 255., b / 255.];

+ red / 255., green / 255., blue / 255.];

}

return NSStringForStringAttribute(