Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1130253004: Normalize JIDs when generating signatures for messages sent to CRD bot. (Closed)

Created:
5 years, 7 months ago by Sergey Ulanov
Modified:
5 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2357
Target Ref:
refs/pending/branch-heads/2357
Project:
chromium
Visibility:
Public.

Description

Normalize JIDs when generating signatures for messages sent to CRD bot. When generating signatures for the messages sent to the bot the JID must be normalized, i.e. node and domain parts must be in lower-case. XmppSignalStrategy::GetLocalJid() was previously returning normalized value, but it was changed recently, which broke hosts that use account with upper-case characters in the name. BUG=485134 Review URL: https://codereview.chromium.org/1131653002 Cr-Commit-Position: refs/heads/master@{#328646} (cherry picked from commit 8916cd0a41e708d4c00e96dae7960cb9e634794e) TBR=sergeyu@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1e71d8c0978c949e6589d459fba2428a5491558c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -8 lines) Patch
M remoting/host/heartbeat_sender.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/heartbeat_sender_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M remoting/host/register_support_host_request.cc View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/host/register_support_host_request_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/remoting_test.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/signaling/jid_util.h View 1 chunk +18 lines, -0 lines 0 comments Download
A remoting/signaling/jid_util.cc View 1 chunk +23 lines, -0 lines 0 comments Download
A remoting/signaling/jid_util_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Sergey Ulanov
5 years, 7 months ago (2015-05-07 22:58:11 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e71d8c0978c949e6589d459fba2428a5491558c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698