Use lower-case JIDs when generating signatures for messages sent to CRD bot.

Normalize JIDs when generating signatures for messages sent to CRD bot.

When generating signatures for the messages sent to the bot the JID
must be normalized, i.e. node and domain parts must be in lower-case.
XmppSignalStrategy::GetLocalJid() was previously returning normalized
value, but it was changed recently, which broke hosts that use account
with upper-case characters in the name.

BUG=485134
Committed: https://crrev.com/8916cd0a41e708d4c00e96dae7960cb9e634794e
Cr-Commit-Position: refs/heads/master@{#328646}

[Sergey Ulanov, 2015-05-06 17:34:49]

sergeyu@chromium.org changed reviewers:
+ rmsousa@chromium.org

[Sergey Ulanov, 2015-05-06 18:12:45]

Actually this patch doesn't work correctly - only node and domain should be in
lower-case, while resource id is case-sensetive. I'll update this CL and will
let you know when it's ready for review.

[Sergey Ulanov, 2015-05-06 18:42:41]

Patchset #2 (id:20001) has been deleted

[Sergey Ulanov, 2015-05-06 19:19:29]

This is ready for review now

[rmsousa, 2015-05-06 21:23:47]

lgtm

lgtm

however, is xmppsignalstrategy::getlocaljid something that we control now? given
that the jid that'll be seen on the wire is normalized, it might be a good idea
to return the normalized value from getlocaljid.

[Sergey Ulanov, 2015-05-06 22:11:38]

On 2015/05/06 21:23:47, rmsousa wrote:
> lgtm
> 
> lgtm
> 
> however, is xmppsignalstrategy::getlocaljid something that we control now?
given
> that the jid that'll be seen on the wire is normalized, it might be a good
idea
> to return the normalized value from getlocaljid.

GetLocalJid() returns the JID the way it's received from the server and
XmppSignalStrategy doesn't normalize it. JIDs are not normalized on wire (Talk
normalizes them  internally when comparing JIDs, e.g. for routing).

[Sergey Ulanov, 2015-05-06 22:11:43]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-05-06 22:12:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1131653002/40001

[commit-bot: I haz the power, 2015-05-06 23:00:26]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-05-06 23:01:23]

Patchset 2 (id:??) landed as
https://crrev.com/8916cd0a41e708d4c00e96dae7960cb9e634794e
Cr-Commit-Position: refs/heads/master@{#328646}