Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1762)

Unified Diff: Source/modules/push_messaging/PushManager.cpp

Issue 1130233003: Reject the permissionState promise with NotSupported Exception (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/push_messaging/PushManager.cpp
diff --git a/Source/modules/push_messaging/PushManager.cpp b/Source/modules/push_messaging/PushManager.cpp
index 90a7f642a0609fd76d63b1742bcce2aaf7792703..ff8512d59d40b7d5e5a251c166d1cc7056c7c362 100644
--- a/Source/modules/push_messaging/PushManager.cpp
+++ b/Source/modules/push_messaging/PushManager.cpp
@@ -41,6 +41,8 @@ WebPushSubscriptionOptions toWebPushSubscriptionOptions(const PushSubscriptionOp
WebPushSubscriptionOptions webOptions;
webOptions.userVisibleOnly = options.userVisibleOnly();
+ // Backfill userVisible since it's still used by the chrome layer.
+ webOptions.userVisible = options.userVisibleOnly();
return webOptions;
}
« no previous file with comments | « Source/modules/push_messaging/PushError.cpp ('k') | Source/modules/push_messaging/PushPermissionStatusCallbacks.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698