Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1782)

Unified Diff: Source/modules/push_messaging/PushPermissionStatusCallbacks.h

Issue 1130233003: Reject the permissionState promise with NotSupported Exception (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/push_messaging/PushPermissionStatusCallbacks.h
diff --git a/Source/modules/push_messaging/PushPermissionStatusCallbacks.h b/Source/modules/push_messaging/PushPermissionStatusCallbacks.h
index b565807c740495d598f4f9bbe3604242fb46dbe6..f42ded215b2b1d672134556e7de2a394745c10d2 100644
--- a/Source/modules/push_messaging/PushPermissionStatusCallbacks.h
+++ b/Source/modules/push_messaging/PushPermissionStatusCallbacks.h
@@ -31,6 +31,9 @@ public:
void onSuccess(WebPushPermissionStatus*) override;
// Called if for some reason the status of the push permission cannot be checked.
+ void onError(WebPushError*) override;
+
+ // TODO(miguelg): Remove this once blinks rolls into chrome
void onError() override;
private:
« no previous file with comments | « Source/modules/push_messaging/PushManager.cpp ('k') | Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698