Source/modules/push_messaging/PushError.cpp - Issue 1130233003: Reject the permissionState promise with NotSupported Exception (1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushError.cpp

Issue 1130233003: Reject the permissionState promise with NotSupported Exception (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js ('k') | Source/modules/push_messaging/PushManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushError.cpp

diff --git a/Source/modules/push_messaging/PushError.cpp b/Source/modules/push_messaging/PushError.cpp

index d4eb8f700016eb6e116143ac0273925b99887080..5eb7e3e39fe07732c2dfc98a875fb69f2df236e4 100644

--- a/Source/modules/push_messaging/PushError.cpp

+++ b/Source/modules/push_messaging/PushError.cpp

@@ -21,6 +21,8 @@ DOMException* PushError::take(ScriptPromiseResolver*, WebType* webErrorRaw)

return DOMException::create(NetworkError, webError->message);

case WebPushError::ErrorTypeNotFound:

return DOMException::create(NotFoundError, webError->message);

+ case WebPushError::ErrorTypeNotSupported:

+ return DOMException::create(NotSupportedError, webError->message);

case WebPushError::ErrorTypeUnknown:

return DOMException::create(UnknownError, webError->message);

}