Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js

Issue 1130233003: Reject the permissionState promise with NotSupported Exception (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js
diff --git a/LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js b/LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js
index c6f5fbc1168b7d24e687c2ce8a5c92f5a826fb6a..81634ca362c48ffe81ef904cfa0dc86433eb39fc 100644
--- a/LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js
+++ b/LayoutTests/http/tests/push_messaging/resources/instrumentation-service-worker.js
@@ -13,10 +13,10 @@ self.addEventListener('message', function(workerEvent) {
port.onmessage = function(event) {
if (typeof event.data != 'object' || !event.data.command)
return;
-
+ var options = event.data.options || {}
switch (event.data.command) {
case 'permissionState':
- self.registration.pushManager.permissionState().then(function(permissionStatus) {
+ self.registration.pushManager.permissionState(options).then(function(permissionStatus) {
port.postMessage({ command: event.data.command,
success: true,
permission: permissionStatus });
@@ -24,7 +24,7 @@ self.addEventListener('message', function(workerEvent) {
break;
case 'subscribe':
- self.registration.pushManager.subscribe().then(function(subscription) {
+ self.registration.pushManager.subscribe(options).then(function(subscription) {
lastSeenSubscription = subscription;
port.postMessage({ command: event.data.command,
success: true,

Powered by Google App Engine
This is Rietveld 408576698