Reject the permissionState promise with NotSupported Exception (1/3)

public/platform/modules/push_messaging/WebPushProvider.h

Index: public/platform/modules/push_messaging/WebPushProvider.h
diff --git a/public/platform/modules/push_messaging/WebPushProvider.h b/public/platform/modules/push_messaging/WebPushProvider.h
index 47fe52241424ddfffb68fcbdcd3df70796f465f8..ad920b917d7e0c227374257bd3104a246675608c 100644
--- a/public/platform/modules/push_messaging/WebPushProvider.h
+++ b/public/platform/modules/push_messaging/WebPushProvider.h
@@ -16,9 +16,20 @@ struct WebPushSubscription;
 struct WebPushSubscriptionOptions;
 
 using WebPushSubscriptionCallbacks = WebCallbacks<WebPushSubscription, WebPushError>;
-using WebPushPermissionStatusCallbacks = WebCallbacks<WebPushPermissionStatus, void>;
+using WebPushPermissionStatusCallbacksOriginal = WebCallbacks<WebPushPermissionStatus, WebPushError>;
 using WebPushUnsubscribeCallbacks = WebCallbacks<bool, WebPushError>;
 
+// FIXME: Remove this and rename WebPushPermissionStatusCallbacksOriginal to WebPushPermissionStatusCallbacks
+// once blinks rolls into chrome and the embedder is fixed to use onError(WebPushError*)
+class WebPushPermissionStatusCallbacks: public WebPushPermissionStatusCallbacksOriginal {

[Peter Beverloo, 2015/05/11 12:56:15]

nit: space before the colon.

[Miguel Garcia, 2015/05/11 13:22:47]

Done.

+public:
+    virtual void onError() = 0;
+
+    // WebPushPermissionStatusCallbacksOriginal:
+    virtual void onSuccess(WebPushPermissionStatus*) = 0;
+    virtual void onError(WebPushError*) = 0;
+};

[Peter Beverloo, 2015/05/11 12:56:15]

Hmm, I haven't seen this mechanism of dealing with updating types in the API
used before, but I like it :-). It could use a comment above line 26 to clarify
that the argument-less onError() method is the one that has to go, but SGTM
otherwise.

[Miguel Garcia, 2015/05/11 13:22:47]

Acknowledged.

+
 class WebPushProvider {
 public:
     virtual ~WebPushProvider() { }