Source/modules/push_messaging/PushPermissionStatusCallbacks.h - Issue 1130233003: Reject the permissionState promise with NotSupported Exception (1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushPermissionStatusCallbacks.h

Issue 1130233003: Reject the permissionState promise with NotSupported Exception (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/push_messaging/PushManager.cpp ('K') | « Source/modules/push_messaging/PushManager.cpp ('k') | Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp » ('j') | public/platform/modules/push_messaging/WebPushProvider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushPermissionStatusCallbacks.h

diff --git a/Source/modules/push_messaging/PushPermissionStatusCallbacks.h b/Source/modules/push_messaging/PushPermissionStatusCallbacks.h

index b565807c740495d598f4f9bbe3604242fb46dbe6..64ab926c2f79141d353a4e30cdf74259970b955c 100644

--- a/Source/modules/push_messaging/PushPermissionStatusCallbacks.h

+++ b/Source/modules/push_messaging/PushPermissionStatusCallbacks.h

@@ -31,6 +31,9 @@ public:

void onSuccess(WebPushPermissionStatus*) override;

// Called if for some reason the status of the push permission cannot be checked.

+ void onError(WebPushError*) override;

+ // FIXME: Remove this once blinks rolls into chrome

Peter Beverloo 2015/05/11 12:56:15 nit: s/FIXME/TODO(miguelg). Elsewhere too, Blink s

Miguel Garcia 2015/05/11 13:22:47 Done.

void onError() override;

private: