Reject the permissionState promise with NotSupported Exception (1/3)

public/platform/modules/push_messaging/WebPushProvider.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebPushProvider_h
 #define WebPushProvider_h
 
 #include "public/platform/WebCallbacks.h"
 #include "public/platform/modules/push_messaging/WebPushPermissionStatus.h"
 
 namespace blink {
 
 class WebServiceWorkerRegistration;
 struct WebPushError;
 struct WebPushSubscription;
 struct WebPushSubscriptionOptions;
 
 using WebPushSubscriptionCallbacks = WebCallbacks<WebPushSubscription, WebPushError>;
-using WebPushPermissionStatusCallbacks = WebCallbacks<WebPushPermissionStatus, void>;
+using WebPushPermissionStatusCallbacksOriginal = WebCallbacks<WebPushPermissionStatus, WebPushError>;
 using WebPushUnsubscribeCallbacks = WebCallbacks<bool, WebPushError>;
 
+// FIXME: Remove this and rename WebPushPermissionStatusCallbacksOriginal to WebPushPermissionStatusCallbacks
+// once blinks rolls into chrome and the embedder is fixed to use onError(WebPushError*)
+class WebPushPermissionStatusCallbacks: public WebPushPermissionStatusCallbacksOriginal {

[Peter Beverloo, 2015/05/11 12:56:15]

nit: space before the colon.

[Miguel Garcia, 2015/05/11 13:22:47]

Done.

+public:
+    virtual void onError() = 0;
+
+    // WebPushPermissionStatusCallbacksOriginal:
+    virtual void onSuccess(WebPushPermissionStatus*) = 0;
+    virtual void onError(WebPushError*) = 0;
+};

[Peter Beverloo, 2015/05/11 12:56:15]

Hmm, I haven't seen this mechanism of dealing with updating types in the API
used before, but I like it :-). It could use a comment above line 26 to clarify
that the argument-less onError() method is the one that has to go, but SGTM
otherwise.

[Miguel Garcia, 2015/05/11 13:22:47]

Acknowledged.

+
 class WebPushProvider {
 public:
     virtual ~WebPushProvider() { }
 
     // Takes ownership of the WebPushSubscriptionCallbacks.
     // Does not take ownership of the WebServiceWorkerRegistration.
     virtual void subscribe(WebServiceWorkerRegistration*, const WebPushSubscriptionOptions&, WebPushSubscriptionCallbacks*) = 0;
 
     // Takes ownership of the WebPushSubscriptionCallbacks.
     // Does not take ownership of the WebServiceWorkerRegistration.
     virtual void getSubscription(WebServiceWorkerRegistration*, WebPushSubscriptionCallbacks*) = 0;
 
     // Takes ownership of the WebPushPermissionStatusCallbacks.
     // Does not take ownership of the WebServiceWorkerRegistration.
     virtual void getPermissionStatus(WebServiceWorkerRegistration*, const WebPushSubscriptionOptions&, WebPushPermissionStatusCallbacks*) = 0;
 
     // Takes ownership if the WebPushUnsubscribeCallbacks.
     // Does not take ownership of the WebServiceWorkerRegistration.
     virtual void unsubscribe(WebServiceWorkerRegistration*, WebPushUnsubscribeCallbacks*) = 0;
 };
 
 } // namespace blink
 
 #endif // WebPushProvider_h