Source/modules/push_messaging/PushManager.cpp - Issue 1130233003: Reject the permissionState promise with NotSupported Exception (1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushManager.cpp

Issue 1130233003: Reject the permissionState promise with NotSupported Exception (1/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/push_messaging/PushError.cpp ('k') | Source/modules/push_messaging/PushPermissionStatusCallbacks.h » ('j') | Source/modules/push_messaging/PushPermissionStatusCallbacks.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushManager.cpp

diff --git a/Source/modules/push_messaging/PushManager.cpp b/Source/modules/push_messaging/PushManager.cpp

index 90a7f642a0609fd76d63b1742bcce2aaf7792703..ff8512d59d40b7d5e5a251c166d1cc7056c7c362 100644

--- a/Source/modules/push_messaging/PushManager.cpp

+++ b/Source/modules/push_messaging/PushManager.cpp

@@ -41,6 +41,8 @@ WebPushSubscriptionOptions toWebPushSubscriptionOptions(const PushSubscriptionOp

WebPushSubscriptionOptions webOptions;

webOptions.userVisibleOnly = options.userVisibleOnly();

+ // Backfill userVisible since it's still used by the chrome layer.

Peter Beverloo 2015/05/11 12:56:15 nit: This is a TODO.

Miguel Garcia 2015/05/11 13:22:47 Acknowledged.

+ webOptions.userVisible = options.userVisibleOnly();

return webOptions;

}