runtime/vm/symbols.cc - Issue 11299084: Correct a misnomer regarding supplementary code points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/symbols.cc

Issue 11299084: Correct a misnomer regarding supplementary code points. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: missed a few uses of smp Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/symbols.cc

diff --git a/runtime/vm/symbols.cc b/runtime/vm/symbols.cc

index b7d8bcff62f0c81d06fa9c3610ef54da0bf16bac..a135ec6092f23dd55e7b9ac6ccdcbfcfb3efafd7 100644

--- a/runtime/vm/symbols.cc

+++ b/runtime/vm/symbols.cc

@@ -112,7 +112,7 @@ RawString* Symbols::New(const char* str) {

Utf8::DecodeToLatin1(utf8_array, str_len, characters, len);

return New(characters, len);

}

- ASSERT((type == Utf8::kBMP) || (type == Utf8::kSMP));

+ ASSERT((type == Utf8::kBMP) || (type == Utf8::kSupplementary));

uint16_t* characters = zone->Alloc<uint16_t>(len);

Utf8::DecodeToUTF16(utf8_array, str_len, characters, len);

return New(characters, len);

« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/unicode.h » ('j') | no next file with comments »