Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: runtime/vm/symbols.cc

Issue 11299084: Correct a misnomer regarding supplementary code points. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: missed a few uses of smp Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/unicode.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/symbols.h" 5 #include "vm/symbols.h"
6 6
7 #include "vm/isolate.h" 7 #include "vm/isolate.h"
8 #include "vm/object.h" 8 #include "vm/object.h"
9 #include "vm/object_store.h" 9 #include "vm/object_store.h"
10 #include "vm/raw_object.h" 10 #include "vm/raw_object.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 intptr_t len = Utf8::CodePointCount(utf8_array, str_len, &type); 105 intptr_t len = Utf8::CodePointCount(utf8_array, str_len, &type);
106 Zone* zone = Isolate::Current()->current_zone(); 106 Zone* zone = Isolate::Current()->current_zone();
107 if (len == 0) { 107 if (len == 0) {
108 return Symbols::New(reinterpret_cast<uint8_t*>(NULL), 0); 108 return Symbols::New(reinterpret_cast<uint8_t*>(NULL), 0);
109 } 109 }
110 if (type == Utf8::kLatin1) { 110 if (type == Utf8::kLatin1) {
111 uint8_t* characters = zone->Alloc<uint8_t>(len); 111 uint8_t* characters = zone->Alloc<uint8_t>(len);
112 Utf8::DecodeToLatin1(utf8_array, str_len, characters, len); 112 Utf8::DecodeToLatin1(utf8_array, str_len, characters, len);
113 return New(characters, len); 113 return New(characters, len);
114 } 114 }
115 ASSERT((type == Utf8::kBMP) || (type == Utf8::kSMP)); 115 ASSERT((type == Utf8::kBMP) || (type == Utf8::kSupplementary));
116 uint16_t* characters = zone->Alloc<uint16_t>(len); 116 uint16_t* characters = zone->Alloc<uint16_t>(len);
117 Utf8::DecodeToUTF16(utf8_array, str_len, characters, len); 117 Utf8::DecodeToUTF16(utf8_array, str_len, characters, len);
118 return New(characters, len); 118 return New(characters, len);
119 } 119 }
120 120
121 121
122 template<typename T> 122 template<typename T>
123 RawString* Symbols::New(const T* characters, intptr_t len) { 123 RawString* Symbols::New(const T* characters, intptr_t len) {
124 Isolate* isolate = Isolate::Current(); 124 Isolate* isolate = Isolate::Current();
125 String& symbol = String::Handle(isolate, String::null()); 125 String& symbol = String::Handle(isolate, String::null());
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 } 323 }
324 324
325 325
326 RawObject* Symbols::GetVMSymbol(intptr_t object_id) { 326 RawObject* Symbols::GetVMSymbol(intptr_t object_id) {
327 ASSERT(IsVMSymbolId(object_id)); 327 ASSERT(IsVMSymbolId(object_id));
328 intptr_t i = (object_id - kMaxPredefinedObjectIds); 328 intptr_t i = (object_id - kMaxPredefinedObjectIds);
329 return (i > 0 && i < Symbols::kMaxId) ? predefined_[i] : Object::null(); 329 return (i > 0 && i < Symbols::kMaxId) ? predefined_[i] : Object::null();
330 } 330 }
331 331
332 } // namespace dart 332 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/unicode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698