runtime/vm/unicode.h - Issue 11299084: Correct a misnomer regarding supplementary code points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/unicode.h

Issue 11299084: Correct a misnomer regarding supplementary code points. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: missed a few uses of smp Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/unicode.h

diff --git a/runtime/vm/unicode.h b/runtime/vm/unicode.h

index 2cb23c04511cbb969a36ea57b367a46a12868811..a53f7afc75bdb6a716de7c37caae3054f0b9157c 100644

--- a/runtime/vm/unicode.h

+++ b/runtime/vm/unicode.h

@@ -15,9 +15,9 @@ class String;

class Utf8 : AllStatic {

public:

enum Type {

- kLatin1 = 0, // Latin-1 character set.

- kBMP, // Basic Multilingual Plane.

- kSMP, // Supplementary Multilingual Plane.

+ kLatin1 = 0, // Latin-1 code point [U+0000, U+00FF].

+ kBMP, // Basic Multilingual Plane code point [U+0000, U+FFFF].

+ kSupplementary, // Supplementary code point [U+010000, U+10FFFF].

};

static const intptr_t kMaxOneByteChar = 0x7F;

« no previous file with comments | « runtime/vm/symbols.cc ('k') | runtime/vm/unicode.cc » ('j') | no next file with comments »