Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1129903002: gpu: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed)

Created:
5 years, 7 months ago by Sami
Modified:
5 years, 7 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Remove use of MessageLoopProxy and deprecated MessageLoop APIs This patch was autogenerated with https://codereview.chromium.org/1010073002/. BUG=465354 Committed: https://crrev.com/0ad2c54d6ec166375aabcbddfca4e82bfb70bc51 Cr-Commit-Position: refs/heads/master@{#328745}

Patch Set 1 #

Patch Set 2 : Cleanup. #

Patch Set 3 : Rebased. #

Patch Set 4 : Really rebase. #

Total comments: 4

Patch Set 5 : Review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -78 lines) Patch
M gpu/command_buffer/common/command_buffer_shared_test.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test.cc View 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_egl.cc View 6 chunks +17 lines, -23 lines 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_share_group.cc View 6 chunks +18 lines, -21 lines 0 comments Download
M gpu/command_buffer/service/gpu_tracer.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 4 chunks +16 lines, -11 lines 0 comments Download
M gpu/command_buffer/tests/gl_readback_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M gpu/tools/compositor_model_bench/compositor_model_bench.cc View 1 2 3 4 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Sami
5 years, 7 months ago (2015-05-06 18:20:33 UTC) #2
no sievers
lgtm https://codereview.chromium.org/1129903002/diff/60001/gpu/command_buffer/common/gles2_cmd_format_test.cc File gpu/command_buffer/common/gles2_cmd_format_test.cc (right): https://codereview.chromium.org/1129903002/diff/60001/gpu/command_buffer/common/gles2_cmd_format_test.cc#newcode7 gpu/command_buffer/common/gles2_cmd_format_test.cc:7: #include "gpu/command_buffer/common/gles2_cmd_format.h" nit: move below std include https://codereview.chromium.org/1129903002/diff/60001/gpu/tools/compositor_model_bench/compositor_model_bench.cc ...
5 years, 7 months ago (2015-05-06 21:51:10 UTC) #3
Sami
Thanks Daniel. https://codereview.chromium.org/1129903002/diff/60001/gpu/command_buffer/common/gles2_cmd_format_test.cc File gpu/command_buffer/common/gles2_cmd_format_test.cc (right): https://codereview.chromium.org/1129903002/diff/60001/gpu/command_buffer/common/gles2_cmd_format_test.cc#newcode7 gpu/command_buffer/common/gles2_cmd_format_test.cc:7: #include "gpu/command_buffer/common/gles2_cmd_format.h" On 2015/05/06 21:51:10, sievers wrote: ...
5 years, 7 months ago (2015-05-07 10:44:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129903002/80001
5 years, 7 months ago (2015-05-07 10:44:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/35064)
5 years, 7 months ago (2015-05-07 11:04:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129903002/80001
5 years, 7 months ago (2015-05-07 11:06:21 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-07 11:52:07 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 11:52:58 UTC) #13
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/0ad2c54d6ec166375aabcbddfca4e82bfb70bc51
Cr-Commit-Position: refs/heads/master@{#328745}

Powered by Google App Engine
This is Rietveld 408576698