gpu/command_buffer/tests/gl_readback_unittest.cc - Issue 1129903002: gpu: Remove use of MessageLoopProxy and deprecated MessageLoop APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/tests/gl_readback_unittest.cc

Issue 1129903002: gpu: Remove use of MessageLoopProxy and deprecated MessageLoop APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/in_process_command_buffer.cc ('k') | gpu/tools/compositor_model_bench/compositor_model_bench.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/tests/gl_readback_unittest.cc

diff --git a/gpu/command_buffer/tests/gl_readback_unittest.cc b/gpu/command_buffer/tests/gl_readback_unittest.cc

index cbda25ccfa8ba204d340cfdaae43a260f8e7c3d0..b4a88ee6726ba87a7d21435505db51c7c011e93a 100644

--- a/gpu/command_buffer/tests/gl_readback_unittest.cc

+++ b/gpu/command_buffer/tests/gl_readback_unittest.cc

@@ -10,8 +10,10 @@

#include "base/basictypes.h"

#include "base/bind.h"

-#include "base/message_loop/message_loop.h"

+#include "base/location.h"

#include "base/run_loop.h"

+#include "base/single_thread_task_runner.h"

+#include "base/thread_task_runner_handle.h"

#include "gpu/command_buffer/tests/gl_manager.h"

#include "gpu/command_buffer/tests/gl_test_utils.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -31,9 +33,8 @@ class GLReadbackTest : public testing::Test {

if (done) {

cb.Run();

} else {

- base::MessageLoop::current()->PostDelayedTask(

- FROM_HERE,

- base::Bind(&WaitForQueryCallback, q, cb),

+ base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

+ FROM_HERE, base::Bind(&WaitForQueryCallback, q, cb),

base::TimeDelta::FromMilliseconds(3));

}