Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1129843003: Make drawImage a virtual on SkDevice (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make drawImage a virtual on SkDevice This reverts commit 06dad4b92f1fcb593bc686f9537d3e0d866b2241. BUG=485243 Committed: https://skia.googlesource.com/skia/+/a85d4d0814818e4ddabb9237da209d61d6cd5854

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -78 lines) Patch
M include/core/SkDevice.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/core/SkImage.h View 1 chunk +0 lines, -13 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +51 lines, -5 lines 0 comments Download
M src/core/SkDevice.cpp View 2 chunks +19 lines, -0 lines 0 comments Download
M src/core/SkPaintPriv.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/core/SkPaintPriv.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 2 chunks +17 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +42 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 4 chunks +20 lines, -0 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 7 chunks +46 lines, -1 line 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 7 chunks +89 lines, -5 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 5 chunks +64 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
reed1
5 years, 7 months ago (2015-05-06 19:42:45 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129843003/20001
5 years, 7 months ago (2015-05-06 19:43:46 UTC) #4
robertphillips
lgtm
5 years, 7 months ago (2015-05-06 19:53:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-06 19:55:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129843003/20001
5 years, 7 months ago (2015-05-06 19:56:05 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 19:56:52 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a85d4d0814818e4ddabb9237da209d61d6cd5854

Powered by Google App Engine
This is Rietveld 408576698