Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1837)

Unified Diff: content/child/push_messaging/push_dispatcher.cc

Issue 1129833003: Rename "register" -> "subscribe" in the Push Messaging code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@p-userVisible-tests
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/push_messaging/push_dispatcher.cc
diff --git a/content/child/push_messaging/push_dispatcher.cc b/content/child/push_messaging/push_dispatcher.cc
index 8cc33fc0dd20e53164d0fa60fbb94cd763af0b36..80d0bbc2d7f2cf1da13e70b1afa577599d5fec6b 100644
--- a/content/child/push_messaging/push_dispatcher.cc
+++ b/content/child/push_messaging/push_dispatcher.cc
@@ -27,14 +27,14 @@ bool PushDispatcher::ShouldHandleMessage(const IPC::Message& msg) const {
// of the API functionality requires a direct association with a document and
// a frame, and for those cases the IPC messages are handled by a
// RenderFrameObserver.
- return msg.type() == PushMessagingMsg_RegisterFromWorkerSuccess::ID ||
- msg.type() == PushMessagingMsg_RegisterFromWorkerError::ID ||
- msg.type() == PushMessagingMsg_GetRegistrationSuccess::ID ||
- msg.type() == PushMessagingMsg_GetRegistrationError::ID ||
+ return msg.type() == PushMessagingMsg_SubscribeFromWorkerSuccess::ID ||
+ msg.type() == PushMessagingMsg_SubscribeFromWorkerError::ID ||
+ msg.type() == PushMessagingMsg_GetSubscriptionSuccess::ID ||
+ msg.type() == PushMessagingMsg_GetSubscriptionError::ID ||
msg.type() == PushMessagingMsg_GetPermissionStatusSuccess::ID ||
msg.type() == PushMessagingMsg_GetPermissionStatusError::ID ||
- msg.type() == PushMessagingMsg_UnregisterSuccess::ID ||
- msg.type() == PushMessagingMsg_UnregisterError::ID;
+ msg.type() == PushMessagingMsg_UnsubscribeSuccess::ID ||
+ msg.type() == PushMessagingMsg_UnsubscribeError::ID;
}
void PushDispatcher::OnFilteredMessageReceived(const IPC::Message& msg) {

Powered by Google App Engine
This is Rietveld 408576698