content/child/push_messaging/push_dispatcher.h - Issue 1129833003: Rename "register" -> "subscribe" in the Push Messaging code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/push_messaging/push_dispatcher.h

Issue 1129833003: Rename "register" -> "subscribe" in the Push Messaging code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@p-userVisible-tests

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/push_messaging/push_messaging_message_filter.cc ('K') | « content/browser/push_messaging/push_messaging_message_filter.cc ('k') | content/child/push_messaging/push_dispatcher.cc » ('j') | content/public/common/push_messaging_status.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/push_messaging/push_dispatcher.h

diff --git a/content/child/push_messaging/push_dispatcher.h b/content/child/push_messaging/push_dispatcher.h

index 5eaf550c2f7c74c2f836aa4e84069c252ea9b416..3ec697bae20a8cf7bd1ebc7fc5711c1d994999c9 100644

--- a/content/child/push_messaging/push_dispatcher.h

+++ b/content/child/push_messaging/push_dispatcher.h

@@ -18,7 +18,7 @@ class PushDispatcher : public WorkerThreadMessageFilter {

// Generates a process-unique new request id. Stores it in a map as key to

// |thread_id| and returns it. This method can be called on any thread.

- // Note that the registration requests from document contexts do not go via

+ // Note that the subscription requests from document contexts do not go via

// this class and their request ids may overlap with the ones generated here.

int GenerateRequestId(int thread_id);