Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: content/child/push_messaging/push_provider.h

Issue 1129833003: Rename "register" -> "subscribe" in the Push Messaging code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@p-userVisible-tests
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/push_messaging/push_provider.h
diff --git a/content/child/push_messaging/push_provider.h b/content/child/push_messaging/push_provider.h
index e44bf41b943af62b3abe8150e8a7eadee1535252..eec02a64d8f0e594c98d7c889a8406aa80566104 100644
--- a/content/child/push_messaging/push_provider.h
+++ b/content/child/push_messaging/push_provider.h
@@ -63,18 +63,19 @@ class PushProvider : public blink::WebPushProvider,
PushDispatcher* push_dispatcher);
// IPC message handlers.
- void OnRegisterFromWorkerSuccess(int request_id,
- const GURL& endpoint,
- const std::string& registration_id);
- void OnRegisterFromWorkerError(int request_id, PushRegistrationStatus status);
- void OnUnregisterSuccess(int request_id, bool did_unregister);
- void OnUnregisterError(int request_id,
- blink::WebPushError::ErrorType error_type,
- const std::string& error_message);
- void OnGetRegistrationSuccess(int request_id,
+ void OnSubscribeFromWorkerSuccess(int request_id,
+ const GURL& endpoint,
+ const std::string& subscription_id);
+ void OnSubscribeFromWorkerError(int request_id,
+ PushSubscriptionStatus status);
+ void OnUnsubscribeSuccess(int request_id, bool did_unsubscribe);
+ void OnUnsubscribeError(int request_id,
+ blink::WebPushError::ErrorType error_type,
+ const std::string& error_message);
+ void OnGetSubscriptionSuccess(int request_id,
const GURL& endpoint,
- const std::string& registration_id);
- void OnGetRegistrationError(int request_id, PushGetRegistrationStatus status);
+ const std::string& subscription_id);
+ void OnGetSubscriptionError(int request_id, PushGetSubscriptionStatus status);
void OnGetPermissionStatusSuccess(int request_id,
blink::WebPushPermissionStatus status);
void OnGetPermissionStatusError(int request_id);

Powered by Google App Engine
This is Rietveld 408576698