Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1129363003: Do not clear stepping after DebugEvaluate. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
yurys
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not clear stepping after DebugEvaluate. Clearing stepping was originally introduced in http://codereview.chromium.org/7889039 But DebugEvaluate now also uses a DisableBreak scope, which makes sure we don't step inside the evaluated code. R=yurys@chromium.org BUG=chromium:467180 LOG=N Committed: https://crrev.com/19312c1631c2cade977c6e94398c5b08361bb717 Cr-Commit-Position: refs/heads/master@{#28461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M src/runtime/runtime-debug.cc View 1 chunk +0 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-467180.js View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
This is the alternative solution to https://codereview.chromium.org/1132643004/ because latter has been reverted.
5 years, 7 months ago (2015-05-18 06:55:06 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129363003/1
5 years, 7 months ago (2015-05-18 06:56:37 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-18 07:21:43 UTC) #5
yurys
lgtm
5 years, 7 months ago (2015-05-18 22:44:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129363003/1
5 years, 7 months ago (2015-05-19 04:54:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 04:56:24 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 04:56:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19312c1631c2cade977c6e94398c5b08361bb717
Cr-Commit-Position: refs/heads/master@{#28461}

Powered by Google App Engine
This is Rietveld 408576698