Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 7889039: Fixing issue 1639, debugger stops stepping outside evaluate. (Closed)

Created:
9 years, 3 months ago by Yang
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fixing issue 1639, debugger stops stepping outside evaluate. BUG=v8:1639 Committed: http://code.google.com/p/v8/source/detail?r=9287

Patch Set 1 #

Patch Set 2 : Adding test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -0 lines) Patch
M src/runtime.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-1639-2.js View 1 1 chunk +93 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Please take a look. This should fix the other issue in http://code.google.com/p/v8/issues/detail?id=1639
9 years, 3 months ago (2011-09-14 15:45:19 UTC) #1
Vyacheslav Egorov (Chromium)
lgtm
9 years, 3 months ago (2011-09-14 15:48:28 UTC) #2
indutny
9 years, 3 months ago (2011-09-14 15:56:34 UTC) #3
lgtm too
tests are passing

Powered by Google App Engine
This is Rietveld 408576698