Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 1129363003: Do not clear stepping after DebugEvaluate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-467180.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/compiler.h" 9 #include "src/compiler.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 2384 matching lines...) Expand 10 before | Expand all | Expand 10 after
2395 Object); 2395 Object);
2396 2396
2397 // Skip the global proxy as it has no properties and always delegates to the 2397 // Skip the global proxy as it has no properties and always delegates to the
2398 // real global object. 2398 // real global object.
2399 if (result->IsJSGlobalProxy()) { 2399 if (result->IsJSGlobalProxy()) {
2400 PrototypeIterator iter(isolate, result); 2400 PrototypeIterator iter(isolate, result);
2401 // TODO(verwaest): This will crash when the global proxy is detached. 2401 // TODO(verwaest): This will crash when the global proxy is detached.
2402 result = Handle<JSObject>::cast(PrototypeIterator::GetCurrent(iter)); 2402 result = Handle<JSObject>::cast(PrototypeIterator::GetCurrent(iter));
2403 } 2403 }
2404 2404
2405 // Clear the oneshot breakpoints so that the debugger does not step further.
2406 isolate->debug()->ClearStepping();
2407 return result; 2405 return result;
2408 } 2406 }
2409 2407
2410 2408
2411 static Handle<JSObject> NewJSObjectWithNullProto(Isolate* isolate) { 2409 static Handle<JSObject> NewJSObjectWithNullProto(Isolate* isolate) {
2412 Handle<JSObject> result = 2410 Handle<JSObject> result =
2413 isolate->factory()->NewJSObject(isolate->object_function()); 2411 isolate->factory()->NewJSObject(isolate->object_function());
2414 Handle<Map> new_map = 2412 Handle<Map> new_map =
2415 Map::Copy(Handle<Map>(result->map()), "ObjectWithNullProto"); 2413 Map::Copy(Handle<Map>(result->map()), "ObjectWithNullProto");
2416 Map::SetPrototype(new_map, isolate->factory()->null_value()); 2414 Map::SetPrototype(new_map, isolate->factory()->null_value());
(...skipping 740 matching lines...) Expand 10 before | Expand all | Expand 10 after
3157 return Smi::FromInt(isolate->debug()->is_active()); 3155 return Smi::FromInt(isolate->debug()->is_active());
3158 } 3156 }
3159 3157
3160 3158
3161 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 3159 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
3162 UNIMPLEMENTED(); 3160 UNIMPLEMENTED();
3163 return NULL; 3161 return NULL;
3164 } 3162 }
3165 } 3163 }
3166 } // namespace v8::internal 3164 } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-467180.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698