Issue 11293277: Fix string whitespace trimming of 0x200b and NEL character.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11293277: Fix string whitespace trimming of 0x200b and NEL character. (Closed)

Created:
8 years, 1 month ago by Michael Starzinger

Modified:
6 years, 9 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix string whitespace trimming of 0x200b and NEL character. R=rossberg@chromium.org BUG=v8:2408 TEST=mjsunit/regress/regress-2408,mjsunit/third_party/string-trim

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -14 lines)			Patch
M	src/runtime.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-2408.js	View	1 chunk	+6 lines, -11 lines	0 comments	Download
M	test/mjsunit/third_party/string-trim.js	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

6 years, 9 months ago (2014-03-07 12:48:18 UTC) #3

Superseded by https://codereview.chromium.org/141323007.

Expand Messages | Collapse Messages