Fix inconsistencies wrt whitespaces.

Fix inconsistencies wrt whitespaces.

This relands r19196 with fixes.

BUG=v8:3109
LOG=Y
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=19222

[Yang, 2014-02-10 09:20:17]

This relands the CL that was rolled back with r19199. Major changes (in second
patch set):

- Removed test/webkit/string-trim.js as suggested by machenbach@. Adapted
duplicate exists in test/mjsunit/third_party/
- v8::internal::Whitespace are now characters that are listed in ECMA-262 5.1,
7.2, and Unicode characters of category 'Zs' (unibrow::WhiteSpace). It no longer
includes LineTerminator characters and NEL. (The old notion of WhiteSpace in V8
actually meant both WhiteSpace *and* LineTerminator values)
- Removed unused table for "Space" in unicode.*.
- Introduced new char-predicate WhiteSpaceOrLineTerminator that includes both
WhiteSpace and LineTerminator values as per spec, 7.2 and 7.3.

[mathiasb, 2014-02-10 09:30:01]

https://codereview.chromium.org/141323007/diff/30001/test/mjsunit/whitespaces.js
File test/mjsunit/whitespaces.js (right):

https://codereview.chromium.org/141323007/diff/30001/test/mjsunit/whitespaces...
test/mjsunit/whitespaces.js:1: // Copyright 2014 the V8 project authors. All
rights reserved.
Quick drive-by comment: please use the new/shorter license header for new files.

    // Copyright 2014 the V8 project authors. All rights reserved.
    // Use of this source code is governed by a BSD-style license that can be
    // found in the LICENSE file.

[Michael Starzinger, 2014-02-10 10:22:32]

https://codereview.chromium.org/141323007/diff/30001/test/mjsunit/third_party...
File test/mjsunit/third_party/string-trim.js (right):

https://codereview.chromium.org/141323007/diff/30001/test/mjsunit/third_party...
test/mjsunit/third_party/string-trim.js:69: // \u200B is not a whitespace
character according to Unicode 6.3.0.
Can we remove this copy of "string-trim" in the third party directory (as it is
a very small subset of the original Webkit tests from Apple) and instead keep
the version in the "webkit" directory.

Within the "webkit" directory, I would update the expectation file instead of
editing the test.

[Yang, 2014-02-10 10:48:27]

Note: Rietveld fails to correctly diff or display string-trim-expected.txt
because it now contains weird whitespace characters. I guess you just have to
trust me on this one :)

https://codereview.chromium.org/141323007/diff/30001/test/mjsunit/third_party...
File test/mjsunit/third_party/string-trim.js (right):

https://codereview.chromium.org/141323007/diff/30001/test/mjsunit/third_party...
test/mjsunit/third_party/string-trim.js:69: // \u200B is not a whitespace
character according to Unicode 6.3.0.
On 2014/02/10 10:22:32, Michael Starzinger wrote:
> Can we remove this copy of "string-trim" in the third party directory (as it
is
> a very small subset of the original Webkit tests from Apple) and instead keep
> the version in the "webkit" directory.
> 
> Within the "webkit" directory, I would update the expectation file instead of
> editing the test.

Done.

https://codereview.chromium.org/141323007/diff/30001/test/mjsunit/whitespaces.js
File test/mjsunit/whitespaces.js (right):

https://codereview.chromium.org/141323007/diff/30001/test/mjsunit/whitespaces...
test/mjsunit/whitespaces.js:1: // Copyright 2014 the V8 project authors. All
rights reserved.
On 2014/02/10 09:30:01, mathiasb wrote:
> Quick drive-by comment: please use the new/shorter license header for new
files.
> 
>     // Copyright 2014 the V8 project authors. All rights reserved.
>     // Use of this source code is governed by a BSD-style license that can be
>     // found in the LICENSE file.

I'm not aware we started using this license header for V8.

[mathiasb, 2014-02-10 10:56:05]

On 2014/02/10 10:48:27, Yang wrote:
> I'm not aware we started using this license header for V8.

Several files already do. See
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/8p4JKV76kig...:

> This policy is intended and expected to cover all projects in the
> Chromium universe, including Chrome OS and V8 (which is already nearly
> compliant).

There was a reminder on blink-dev recently:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/oSaYHvSLg2M/3-...

[Michael Starzinger, 2014-02-10 11:23:04]

LGTM (didn't verify against the spec).

[Yang, 2014-02-10 12:42:20]

On 2014/02/10 10:56:05, mathiasb wrote:
> On 2014/02/10 10:48:27, Yang wrote:
> > I'm not aware we started using this license header for V8.
> 
> Several files already do. See
>
https://groups.google.com/a/chromium.org/forum/#%21msg/chromium-dev/8p4JKV76k...:
> 
> > This policy is intended and expected to cover all projects in the
> > Chromium universe, including Chrome OS and V8 (which is already nearly
> > compliant).
> 
> There was a reminder on blink-dev recently:
>
https://groups.google.com/a/chromium.org/forum/#%21msg/blink-dev/oSaYHvSLg2M/...

I guess you are right. Thanks!

[Yang, 2014-02-10 12:43:23]

Committed patchset #4 manually as r19222 (presubmit successful).

[Yang, 2014-02-10 12:54:50]

On 2014/02/10 10:56:05, mathiasb wrote:
> On 2014/02/10 10:48:27, Yang wrote:
> > I'm not aware we started using this license header for V8.
> 
> Several files already do. See
>
https://groups.google.com/a/chromium.org/forum/#%21msg/chromium-dev/8p4JKV76k...:
> 
> > This policy is intended and expected to cover all projects in the
> > Chromium universe, including Chrome OS and V8 (which is already nearly
> > compliant).
> 
> There was a reminder on blink-dev recently:
>
https://groups.google.com/a/chromium.org/forum/#%21msg/blink-dev/oSaYHvSLg2M/...

I guess you are right.