Update histograms.xml for recent BadMessage values.

Update histograms.xml for recent BadMessage values.

BUG=486916
TEST=Histogram properly labeled

Committed: https://crrev.com/ee45bf440c7054f88f66326bca6d4b939ee45933
Cr-Commit-Position: refs/heads/master@{#329439}

[Charlie Reis, 2015-05-11 22:08:18]

creis@chromium.org changed reviewers:
+ avi@chromium.org, mpearson@chromium.org, rockot@chromium.org

[Charlie Reis, 2015-05-11 22:09:45]

Adding some missing histogram values, plus a reminder (since I've missed this
step a few times).

avi: Can you review content/?
rockot: Can you review extensions/?
mpearson: Can you review histograms.xml?

https://codereview.chromium.org/1128993005/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1128993005/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:47641: -  <int value="17"
label="DFH_BAD_EMBEDDER_MESSAGE"/>
This had the wrong value because RFPH_DETACH hadn't been added yet.

[Ken Rockot(use gerrit already), 2015-05-11 22:10:52]

extensions lgtm

[Mark P, 2015-05-11 22:19:01]

histograms.xml lgtm

https://codereview.chromium.org/1128993005/diff/1/content/browser/bad_message.h
File content/browser/bad_message.h (right):

https://codereview.chromium.org/1128993005/diff/1/content/browser/bad_message...
content/browser/bad_message.h:23: NC_IN_PAGE_NAVIGATION = 0,
It's good practice to explicitly do = 0, = 1, etc. all the way down.  This way
if someone inadvertently removes an item from the enum, it doesn't screw
everything up.  (That said, you still shouldn't remove items.)

ditto on other file

[Charlie Reis, 2015-05-11 22:37:58]

Thanks, good idea.

https://codereview.chromium.org/1128993005/diff/1/content/browser/bad_message.h
File content/browser/bad_message.h (right):

https://codereview.chromium.org/1128993005/diff/1/content/browser/bad_message...
content/browser/bad_message.h:23: NC_IN_PAGE_NAVIGATION = 0,
On 2015/05/11 22:19:01, Mark P wrote:
> It's good practice to explicitly do = 0, = 1, etc. all the way down.  This way
> if someone inadvertently removes an item from the enum, it doesn't screw
> everything up.  (That said, you still shouldn't remove items.)
> 
> ditto on other file

Done.

[Avi (use Gerrit), 2015-05-12 17:06:19]

lgtm

[Charlie Reis, 2015-05-12 17:08:06]

The CQ bit was checked by creis@chromium.org

[Charlie Reis, 2015-05-12 17:08:06]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/1128993005/#ps20001
(title: "Add explicit numbering")

[commit-bot: I haz the power, 2015-05-12 17:08:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1128993005/20001

[commit-bot: I haz the power, 2015-05-12 18:00:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-12 18:01:13]

Patchset 2 (id:??) landed as
https://crrev.com/ee45bf440c7054f88f66326bca6d4b939ee45933
Cr-Commit-Position: refs/heads/master@{#329439}