Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2021)

Unified Diff: extensions/browser/bad_message.h

Issue 1128993005: Update histograms.xml for recent BadMessage values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add explicit numbering Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/bad_message.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/bad_message.h
diff --git a/extensions/browser/bad_message.h b/extensions/browser/bad_message.h
index 059636e379b021fa5099a532674c1141f8972dac..ab26aba6a3b3bfd21aa5a7b4340f4177dd150407 100644
--- a/extensions/browser/bad_message.h
+++ b/extensions/browser/bad_message.h
@@ -19,12 +19,12 @@ namespace bad_message {
//
// NOTE: Do not remove or reorder elements in this list. Add new entries at the
// end. Items may be renamed but do not change the values. We rely on the enum
-// values in histograms.
+// values in histograms. Also update histograms.xml with any new values.
enum BadMessageReason {
EOG_BAD_ORIGIN = 0,
- EVG_BAD_ORIGIN,
- BH_BLOB_NOT_OWNED,
- EH_BAD_EVENT_ID,
+ EVG_BAD_ORIGIN = 1,
+ BH_BLOB_NOT_OWNED = 2,
+ EH_BAD_EVENT_ID = 3,
// Please add new elements here. The naming convention is abbreviated class
// name (e.g. ExtensionHost becomes EH) plus a unique description of the
// reason.
« no previous file with comments | « content/browser/bad_message.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698