Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: extensions/browser/bad_message.h

Issue 1128993005: Update histograms.xml for recent BadMessage values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add explicit numbering Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/bad_message.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_BAD_MESSAGE_H_ 5 #ifndef EXTENSIONS_BROWSER_BAD_MESSAGE_H_
6 #define EXTENSIONS_BROWSER_BAD_MESSAGE_H_ 6 #define EXTENSIONS_BROWSER_BAD_MESSAGE_H_
7 7
8 namespace content { 8 namespace content {
9 class RenderProcessHost; 9 class RenderProcessHost;
10 } 10 }
11 11
12 namespace extensions { 12 namespace extensions {
13 namespace bad_message { 13 namespace bad_message {
14 14
15 // The browser process often chooses to terminate a renderer if it receives 15 // The browser process often chooses to terminate a renderer if it receives
16 // a bad IPC message. The reasons are tracked for metrics. 16 // a bad IPC message. The reasons are tracked for metrics.
17 // 17 //
18 // See also content/browser/bad_message.h. 18 // See also content/browser/bad_message.h.
19 // 19 //
20 // NOTE: Do not remove or reorder elements in this list. Add new entries at the 20 // NOTE: Do not remove or reorder elements in this list. Add new entries at the
21 // end. Items may be renamed but do not change the values. We rely on the enum 21 // end. Items may be renamed but do not change the values. We rely on the enum
22 // values in histograms. 22 // values in histograms. Also update histograms.xml with any new values.
23 enum BadMessageReason { 23 enum BadMessageReason {
24 EOG_BAD_ORIGIN = 0, 24 EOG_BAD_ORIGIN = 0,
25 EVG_BAD_ORIGIN, 25 EVG_BAD_ORIGIN = 1,
26 BH_BLOB_NOT_OWNED, 26 BH_BLOB_NOT_OWNED = 2,
27 EH_BAD_EVENT_ID, 27 EH_BAD_EVENT_ID = 3,
28 // Please add new elements here. The naming convention is abbreviated class 28 // Please add new elements here. The naming convention is abbreviated class
29 // name (e.g. ExtensionHost becomes EH) plus a unique description of the 29 // name (e.g. ExtensionHost becomes EH) plus a unique description of the
30 // reason. 30 // reason.
31 BAD_MESSAGE_MAX 31 BAD_MESSAGE_MAX
32 }; 32 };
33 33
34 // Called when the browser receives a bad IPC message from an extension process. 34 // Called when the browser receives a bad IPC message from an extension process.
35 // Logs the event, records a histogram metric for the |reason|, and terminates 35 // Logs the event, records a histogram metric for the |reason|, and terminates
36 // the process for |host|. 36 // the process for |host|.
37 void ReceivedBadMessage(content::RenderProcessHost* host, 37 void ReceivedBadMessage(content::RenderProcessHost* host,
38 BadMessageReason reason); 38 BadMessageReason reason);
39 39
40 } // bad_message 40 } // bad_message
41 } // namespace extensions 41 } // namespace extensions
42 42
43 #endif // EXTENSIONS_BROWSER_BAD_MESSAGE_H_ 43 #endif // EXTENSIONS_BROWSER_BAD_MESSAGE_H_
OLDNEW
« no previous file with comments | « content/browser/bad_message.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698