Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1128933005: Revert of Adjusts dragging logic to be less likely to trigger false positive switch from snapping to docking (Closed)

Created:
5 years, 7 months ago by Dirk Pranke
Modified:
5 years, 7 months ago
Reviewers:
pkotwicz, varkha
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adjusts dragging logic to be less likely to trigger false positive switch from snapping to docking (patchset #5 id:90001 of https://codereview.chromium.org/1127133003/) Reason for revert: I suspect this is causing a browser_tests failure on the bots: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/2069 https://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/1913 Sorry! Original issue's description: > Adjusts dragging logic to be less likely to trigger false positive switch from > snapping to docking. > > This CL adjusts the logic which selects whether a window will be snapped to > half of the workspace width or will be docked at the end of the drag when the > window is dragged to the edge of the workspace in the special case of the dock > being visible. The CL makes it easier to snap a window to half the workspace > width in this special case (and harder to inadvertently dock the window) > > BUG=484877 > TEST=None > > Committed: https://crrev.com/988c697aff35b3fd347dec35f2f2ac159c8328a9 > Cr-Commit-Position: refs/heads/master@{#329268} TBR=pkotwicz@chromium.org,varkha@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484877 Committed: https://crrev.com/0d4f7d597774f7415f1aff374db498c8fbe88a9a Cr-Commit-Position: refs/heads/master@{#329301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -55 lines) Patch
M ash/wm/workspace/two_step_edge_cycler.h View 2 chunks +1 line, -13 lines 0 comments Download
M ash/wm/workspace/two_step_edge_cycler.cc View 2 chunks +12 lines, -30 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 1 chunk +10 lines, -5 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
Created Revert of Adjusts dragging logic to be less likely to trigger false positive switch ...
5 years, 7 months ago (2015-05-12 00:51:06 UTC) #1
varkha
5 years, 7 months ago (2015-05-12 16:07:10 UTC) #2
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1140733002/ by varkha@chromium.org.

The reason for reverting is: This revert probably did not cause the flakiness. I
suspect that this revert actually ended up fixing the bots:
https://codereview.chromium.org/1139943002.

I will re-land my original change..

Powered by Google App Engine
This is Rietveld 408576698