Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 1139943002: Revert of Refactor the avatar button/icon class (Closed)

Created:
5 years, 7 months ago by pneubeck (no reviews)
Modified:
5 years, 7 months ago
Reviewers:
yao, msw, noms (inactive)
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor the avatar button/icon class (patchset #14 id:320001 of https://codereview.chromium.org/1009403002/) Reason for revert: Very likely has caused the latest flakiness of BrowserNonClientFrameViewAshTest.AvatarDisplayOnTeleportedWindow and BrowserNonClientFrameViewAshTest.AvatarMenuButtonHitTestOnChromeOS on ChromeOS dbg: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/2069 Original issue's description: > Refactor the avatar button/icon class. > Such that they are based on the same base class. > > BUG=452524 > > Committed: https://crrev.com/56078ce434955a67159b59303f6691adb55d7ca1 > Cr-Commit-Position: refs/heads/master@{#329249} TBR=noms@chromium.org,msw@chromium.org,yiyaoliu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452524 Committed: https://crrev.com/73d41c0f28f554afca1771020363ca0daee24195 Cr-Commit-Position: refs/heads/master@{#329394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -155 lines) Patch
M chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 1 chunk +20 lines, -0 lines 0 comments Download
D chrome/browser/ui/views/profiles/avatar_base_button.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/ui/views/profiles/avatar_base_button.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_button.h View 4 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/profiles/avatar_menu_button.cc View 4 chunks +3 lines, -23 lines 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.h View 2 chunks +18 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/profiles/new_avatar_button.cc View 6 chunks +45 lines, -15 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pneubeck (no reviews)
Created Revert of Refactor the avatar button/icon class
5 years, 7 months ago (2015-05-12 12:28:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139943002/1
5 years, 7 months ago (2015-05-12 12:28:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 12:29:00 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 12:29:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73d41c0f28f554afca1771020363ca0daee24195
Cr-Commit-Position: refs/heads/master@{#329394}

Powered by Google App Engine
This is Rietveld 408576698