Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Side by Side Diff: ash/wm/workspace/two_step_edge_cycler.cc

Issue 1128933005: Revert of Adjusts dragging logic to be less likely to trigger false positive switch from snapping to docking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/wm/workspace/two_step_edge_cycler.h ('k') | ash/wm/workspace/workspace_window_resizer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/wm/workspace/two_step_edge_cycler.h" 5 #include "ash/wm/workspace/two_step_edge_cycler.h"
6 6
7 #include <cstdlib> 7 #include <cstdlib>
8 8
9 namespace ash { 9 namespace ash {
10 namespace { 10 namespace {
11 11
12 // We cycle to the second mode if any of the following happens while the mouse 12 // We cycle to the second mode if any of the following happens while the mouse
13 // is on the edge of the workspace: 13 // is on the edge of the workspace:
14 // . The user stops moving the mouse for |kMaxDelay| and then moves the mouse 14 // . The user stops moving the mouse for |kMaxDelay| and then moves the mouse
15 // again in the preferred direction from the last paused location for at least 15 // again.
16 // |kMaxPixelsAfterPause| horizontal pixels. 16 // . The mouse moves |kMaxPixels| horizontal pixels.
17 // . The mouse moves |kMaxPixels| horizontal pixels in the preferred direction. 17 // . The mouse is moved |kMaxMoves| times.
18 // . The mouse is moved |kMaxMoves| times since the last pause. 18 const int kMaxDelay = 500;
19 const int kMaxDelay = 400;
20 const int kMaxPixels = 100; 19 const int kMaxPixels = 100;
21 const int kMaxPixelsAfterPause = 10;
22 const int kMaxMoves = 25; 20 const int kMaxMoves = 25;
23 21
24 } // namespace 22 } // namespace
25 23
26 TwoStepEdgeCycler::TwoStepEdgeCycler(const gfx::Point& start, 24 TwoStepEdgeCycler::TwoStepEdgeCycler(const gfx::Point& start)
27 TwoStepEdgeCycler::Direction direction)
28 : second_mode_(false), 25 : second_mode_(false),
29 time_last_move_(base::TimeTicks::Now()), 26 time_last_move_(base::TimeTicks::Now()),
30 num_moves_(0), 27 num_moves_(0),
31 start_x_(start.x()), 28 start_x_(start.x()) {
32 paused_x_(start.x()),
33 paused_(false),
34 direction_(direction) {
35 } 29 }
36 30
37 TwoStepEdgeCycler::~TwoStepEdgeCycler() { 31 TwoStepEdgeCycler::~TwoStepEdgeCycler() {
38 } 32 }
39 33
40 void TwoStepEdgeCycler::OnMove(const gfx::Point& location) { 34 void TwoStepEdgeCycler::OnMove(const gfx::Point& location) {
41 if (second_mode_) 35 if (second_mode_)
42 return; 36 return;
43 37
44 if ((base::TimeTicks::Now() - time_last_move_).InMilliseconds() > kMaxDelay) { 38 ++num_moves_;
45 paused_ = true; 39 second_mode_ =
46 paused_x_ = location.x(); 40 (base::TimeTicks::Now() - time_last_move_).InMilliseconds() >
47 num_moves_ = 0; 41 kMaxDelay ||
48 } 42 std::abs(location.x() - start_x_) >= kMaxPixels ||
43 num_moves_ >= kMaxMoves;
49 time_last_move_ = base::TimeTicks::Now(); 44 time_last_move_ = base::TimeTicks::Now();
50
51 int compare_x = paused_ ? paused_x_ : start_x_;
52 if (location.x() != compare_x &&
53 (location.x() < compare_x) != (direction_ == DIRECTION_LEFT)) {
54 return;
55 }
56
57 ++num_moves_;
58 bool moved_in_the_same_direction_after_pause =
59 paused_ && std::abs(location.x() - paused_x_) >= kMaxPixelsAfterPause;
60 second_mode_ = moved_in_the_same_direction_after_pause ||
61 std::abs(location.x() - start_x_) >= kMaxPixels ||
62 num_moves_ >= kMaxMoves;
63 } 45 }
64 46
65 } // namespace ash 47 } // namespace ash
OLDNEW
« no previous file with comments | « ash/wm/workspace/two_step_edge_cycler.h ('k') | ash/wm/workspace/workspace_window_resizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698