Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1128383002: pkg/(unit)test: Enable group names containing spaces in HtmlIndividualConfiguration (Closed)

Created:
5 years, 7 months ago by kevmoo
Modified:
5 years, 7 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/test.git@stable
Target Ref:
refs/heads/stable
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M CHANGELOG.md View 1 1 chunk +6 lines, -0 lines 0 comments Download
M lib/html_individual_config.dart View 1 1 chunk +14 lines, -18 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
5 years, 7 months ago (2015-05-07 01:39:52 UTC) #2
nweiz
https://codereview.chromium.org/1128383002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1128383002/diff/1/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Fix [an issue][23156] with `HtmlIndividualConfiguration` and tests with ...
5 years, 7 months ago (2015-05-07 01:41:53 UTC) #3
kevmoo
PTAL https://codereview.chromium.org/1128383002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/1128383002/diff/1/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Fix [an issue][23156] with `HtmlIndividualConfiguration` and tests ...
5 years, 7 months ago (2015-05-07 22:39:45 UTC) #4
nweiz
lgtm
5 years, 7 months ago (2015-05-07 22:51:03 UTC) #5
kevmoo
5 years, 7 months ago (2015-05-07 22:56:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e11f42991f24288fa3e37bab61c2742859c057cc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698