Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Side by Side Diff: lib/html_individual_config.dart

Issue 1128383002: pkg/(unit)test: Enable group names containing spaces in HtmlIndividualConfiguration (Closed) Base URL: https://github.com/dart-lang/test.git@stable
Patch Set: nits Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « CHANGELOG.md ('k') | pubspec.yaml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// A unit test library for running groups of tests in a browser, instead of the 5 /// A unit test library for running groups of tests in a browser, instead of the
6 /// entire test file. This is especially used for large tests files that have 6 /// entire test file. This is especially used for large tests files that have
7 /// many subtests, so we can mark groups as failing at a finer granularity than 7 /// many subtests, so we can mark groups as failing at a finer granularity than
8 /// the entire test file. 8 /// the entire test file.
9 /// 9 ///
10 /// To use, import this file, and call [useHtmlIndividualConfiguration] at the 10 /// To use, import this file, and call [useHtmlIndividualConfiguration] at the
11 /// start of your set sequence. Important constraint: your group descriptions 11 /// start of your set sequence. Important constraint: your group descriptions
12 /// MUST NOT contain spaces. 12 /// MUST NOT contain spaces.
13 library unittest.html_individual_config; 13 library unittest.html_individual_config;
14 14
15 import 'dart:html'; 15 import 'dart:html';
16 import 'unittest.dart' as unittest; 16 import 'unittest.dart' as unittest;
17 import 'html_config.dart' as htmlconfig; 17 import 'html_config.dart' as htmlconfig;
18 18
19 class HtmlIndividualConfiguration extends htmlconfig.HtmlConfiguration { 19 class HtmlIndividualConfiguration extends htmlconfig.HtmlConfiguration {
20 HtmlIndividualConfiguration(bool isLayoutTest) : super(isLayoutTest); 20 HtmlIndividualConfiguration(bool isLayoutTest) : super(isLayoutTest);
21 21
22 void onStart() { 22 void onStart() {
23 var search = window.location.search; 23 var uri = Uri.parse(window.location.href);
24 if (search != '') {
25 var groups = search
26 .substring(1)
27 .split('&')
28 .where((p) => p.startsWith('group='))
29 .toList();
30 24
31 if (!groups.isEmpty) { 25 var groups = 'group='.allMatches(uri.query).toList();
32 if (groups.length > 1) {
33 throw new ArgumentError('More than one "group" parameter provided.');
34 }
35 26
36 var testGroupName = groups.single.split('=')[1]; 27 if (groups.length > 1) {
37 var startsWith = "$testGroupName${unittest.groupSep}"; 28 throw new ArgumentError('More than one "group" parameter provided.');
38 unittest.filterTests( 29 }
39 (unittest.TestCase tc) => tc.description.startsWith(startsWith)); 30
40 } 31 var testGroupName = uri.queryParameters['group'];
32
33 if (testGroupName != null) {
34 var startsWith = "$testGroupName${unittest.groupSep}";
35 unittest.filterTests(
36 (unittest.TestCase tc) => tc.description.startsWith(startsWith));
41 } 37 }
42 super.onStart(); 38 super.onStart();
43 } 39 }
44 } 40 }
45 41
46 void useHtmlIndividualConfiguration([bool isLayoutTest = false]) { 42 void useHtmlIndividualConfiguration([bool isLayoutTest = false]) {
47 unittest.unittestConfiguration = 43 unittest.unittestConfiguration =
48 isLayoutTest ? _singletonLayout : _singletonNotLayout; 44 isLayoutTest ? _singletonLayout : _singletonNotLayout;
49 } 45 }
50 46
51 final _singletonLayout = new HtmlIndividualConfiguration(true); 47 final _singletonLayout = new HtmlIndividualConfiguration(true);
52 final _singletonNotLayout = new HtmlIndividualConfiguration(false); 48 final _singletonNotLayout = new HtmlIndividualConfiguration(false);
OLDNEW
« no previous file with comments | « CHANGELOG.md ('k') | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698