Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128273005: Devtools: Move runMessageLoopOnPause and other methods on ScriptDebugServer::Client (Closed)

Created:
5 years, 7 months ago by sergeyv
Modified:
5 years, 7 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg_samsung, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org, oilpan-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Move runMessageLoopOnPause and other methods on ScriptDebugServer::Client BUG=466631 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195134

Patch Set 1 #

Patch Set 2 : PageSDS inherits PerIsolateDebuggerClient #

Patch Set 3 : Remove empty line #

Total comments: 8

Patch Set 4 : Address comments #

Patch Set 5 : Fix ownptrs #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -79 lines) Patch
M Source/bindings/core/v8/PageScriptDebugServer.h View 1 2 3 3 chunks +4 lines, -4 lines 1 comment Download
M Source/bindings/core/v8/PageScriptDebugServer.cpp View 1 2 3 4 6 chunks +7 lines, -17 lines 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.h View 1 2 3 4 3 chunks +5 lines, -8 lines 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.cpp View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/V8PerIsolateData.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8PerIsolateData.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WorkerScriptDebugServer.h View 1 2 3 3 chunks +5 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptDebugServer.cpp View 1 2 3 4 4 chunks +6 lines, -13 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/PerIsolateDebuggerClient.h View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/inspector/PerIsolateDebuggerClient.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 3 4 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
sergeyv
5 years, 7 months ago (2015-05-07 15:24:30 UTC) #2
yurys
Let's not pass client ownership to SDS but have PageScriptDebugServer implement it and hold instance ...
5 years, 7 months ago (2015-05-07 15:30:39 UTC) #3
sergeyv
please take a look
5 years, 7 months ago (2015-05-08 10:46:36 UTC) #6
yurys
lgtm https://codereview.chromium.org/1128273005/diff/80001/Source/bindings/core/v8/PageScriptDebugServer.h File Source/bindings/core/v8/PageScriptDebugServer.h (left): https://codereview.chromium.org/1128273005/diff/80001/Source/bindings/core/v8/PageScriptDebugServer.h#oldcode58 Source/bindings/core/v8/PageScriptDebugServer.h:58: DECLARE_VIRTUAL_TRACE(); This will likely need some work to ...
5 years, 7 months ago (2015-05-08 10:59:15 UTC) #7
yurys
+cc: oilpan-reviews
5 years, 7 months ago (2015-05-08 11:00:04 UTC) #8
sergeyv
https://codereview.chromium.org/1128273005/diff/80001/Source/bindings/core/v8/PageScriptDebugServer.h File Source/bindings/core/v8/PageScriptDebugServer.h (left): https://codereview.chromium.org/1128273005/diff/80001/Source/bindings/core/v8/PageScriptDebugServer.h#oldcode58 Source/bindings/core/v8/PageScriptDebugServer.h:58: DECLARE_VIRTUAL_TRACE(); On 2015/05/08 10:59:15, yurys wrote: > This will ...
5 years, 7 months ago (2015-05-08 13:59:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128273005/40002
5 years, 7 months ago (2015-05-08 20:03:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128273005/40002
5 years, 7 months ago (2015-05-08 21:13:33 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:40002) as https://src.chromium.org/viewvc/blink?view=rev&revision=195134
5 years, 7 months ago (2015-05-09 01:35:25 UTC) #16
pfeldman
https://codereview.chromium.org/1128273005/diff/40002/Source/bindings/core/v8/PageScriptDebugServer.h File Source/bindings/core/v8/PageScriptDebugServer.h (left): https://codereview.chromium.org/1128273005/diff/40002/Source/bindings/core/v8/PageScriptDebugServer.h#oldcode46 Source/bindings/core/v8/PageScriptDebugServer.h:46: class CORE_EXPORT PageScriptDebugServer final : public ScriptDebugServer { So ...
5 years, 7 months ago (2015-05-11 07:25:02 UTC) #18
pfeldman
On 2015/05/11 07:25:02, pfeldman_ooo_may11 wrote: > https://codereview.chromium.org/1128273005/diff/40002/Source/bindings/core/v8/PageScriptDebugServer.h > File Source/bindings/core/v8/PageScriptDebugServer.h (left): > > https://codereview.chromium.org/1128273005/diff/40002/Source/bindings/core/v8/PageScriptDebugServer.h#oldcode46 > ...
5 years, 7 months ago (2015-05-11 07:26:23 UTC) #19
pfeldman
5 years, 7 months ago (2015-05-11 07:27:26 UTC) #20
Message was sent while issue was closed. 
... but it still allows adding ScriptDebugListeners onto itself. Something
clearly needs better naming.

Powered by Google App Engine
This is Rietveld 408576698