Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.cpp

Issue 1128273005: Devtools: Move runMessageLoopOnPause and other methods on ScriptDebugServer::Client (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix ownptrs Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptDebugServer.cpp
diff --git a/Source/bindings/core/v8/ScriptDebugServer.cpp b/Source/bindings/core/v8/ScriptDebugServer.cpp
index 16afeef37cbbbce3ed087a13ec14e963d7fb03e8..f57280ddb1627b7d51379f27ef2f1151187a2643 100644
--- a/Source/bindings/core/v8/ScriptDebugServer.cpp
+++ b/Source/bindings/core/v8/ScriptDebugServer.cpp
@@ -80,7 +80,7 @@ v8::MaybeLocal<v8::Value> ScriptDebugServer::callDebuggerMethod(const char* func
return V8ScriptRunner::callInternalFunction(function, debuggerScript, argc, argv, m_isolate);
}
-ScriptDebugServer::ScriptDebugServer(v8::Isolate* isolate, PassOwnPtr<Client> client)
+ScriptDebugServer::ScriptDebugServer(v8::Isolate* isolate, Client* client)
: m_isolate(isolate)
, m_client(client)
, m_breakpointsActivated(true)
@@ -273,7 +273,7 @@ void ScriptDebugServer::breakProgram()
void ScriptDebugServer::continueProgram()
{
if (isPaused())
- quitMessageLoopOnPause();
+ m_client->quitMessageLoopOnPause();
m_pausedScriptState.clear();
m_executionState.Clear();
}
@@ -522,7 +522,7 @@ void ScriptDebugServer::handleProgramBreak(ScriptState* pausedScriptState, v8::L
if (m_runningNestedMessageLoop)
return;
- ScriptDebugListener* listener = getDebugListenerForContext(pausedScriptState->context());
+ ScriptDebugListener* listener = m_client->getDebugListenerForContext(pausedScriptState->context());
if (!listener)
return;
@@ -541,7 +541,7 @@ void ScriptDebugServer::handleProgramBreak(ScriptState* pausedScriptState, v8::L
ScriptDebugListener::SkipPauseRequest result = listener->didPause(pausedScriptState, currentCallFrames(), ScriptValue(pausedScriptState, exception), breakpointIds, isPromiseRejection);
if (result == ScriptDebugListener::NoSkip) {
m_runningNestedMessageLoop = true;
- runMessageLoopOnPause(pausedScriptState->context());
+ m_client->runMessageLoopOnPause(pausedScriptState->context());
m_runningNestedMessageLoop = false;
}
m_pausedScriptState.clear();
@@ -589,7 +589,7 @@ void ScriptDebugServer::handleV8DebugEvent(const v8::Debug::EventDetails& eventD
v8::Local<v8::Context> eventContext = eventDetails.GetEventContext();
ASSERT(!eventContext.IsEmpty());
- ScriptDebugListener* listener = getDebugListenerForContext(eventContext);
+ ScriptDebugListener* listener = m_client->getDebugListenerForContext(eventContext);
if (listener) {
v8::HandleScope scope(m_isolate);
if (event == v8::AfterCompile || event == v8::CompileError) {

Powered by Google App Engine
This is Rietveld 408576698