Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 1128233004: Fix GpuChannelHost destruction and races (Closed)

Created:
4 years ago by piman
Modified:
4 years ago
Reviewers:
jbauman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GpuChannelHost destruction and races https://codereview.chromium.org/583043005 introduced GpuChannelHost::DestroyChannel but it introduced a new state to GpuChannelHost which was not captured everywhere and had races. 1- Ensure GpuChannelHost::DestroyChannel is always called on the main thread, before destruction. 2- properly handle the channel_ == NULL state. 3- Fix races (channel_ is used on any thread on windows, must be locked) Also make sure contexts are destroyed before the channel, for sanity. BUG=451456, 471822 Committed: https://crrev.com/765e52870520c6e60d913c307577c1d1fec3a381 Cr-Commit-Position: refs/heads/master@{#328917}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 5 chunks +22 lines, -5 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
piman
This probably interacts with your https://codereview.chromium.org/1117183006/ but we should be able to resolve conflicts realtively ...
4 years ago (2015-05-07 22:04:45 UTC) #2
jbauman
lgtm
4 years ago (2015-05-07 23:31:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128233004/1
4 years ago (2015-05-08 01:31:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2015-05-08 03:43:12 UTC) #6
commit-bot: I haz the power
4 years ago (2015-05-08 03:44:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/765e52870520c6e60d913c307577c1d1fec3a381
Cr-Commit-Position: refs/heads/master@{#328917}

Powered by Google App Engine
This is Rietveld 408576698