Issue 1117183006: Remove BrowserGpuChannelHostFactory usage of UnsafeGetMessageLoopForThread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1117183006: Remove BrowserGpuChannelHostFactory usage of UnsafeGetMessageLoopForThread (Closed)

Created:
5 years, 7 months ago by jbauman

Modified:
5 years, 7 months ago

Reviewers:
piman

CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove BrowserGpuChannelHostFactory usage of UnsafeGetMessageLoopForThread Hopefully make its lifetime more explicit. BUG=345432, 436172

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -26 lines)			Patch
M	content/browser/gpu/browser_gpu_channel_host_factory.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/gpu/browser_gpu_channel_host_factory.cc	View		4 chunks	+6 lines, -8 lines	0 comments	Download
M	content/common/gpu/client/gpu_channel_host.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	content/common/gpu/client/gpu_channel_host.cc	View		3 chunks	+8 lines, -4 lines	0 comments	Download
M	content/renderer/render_thread_impl.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1	3 chunks	+5 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages