Chromium Code Reviews

Issue 1128213006: Fixed Chrome OS password changing dialog. (Closed)

Created:
5 years, 7 months ago by dzhioev (left Google)
Modified:
5 years, 7 months ago
Reviewers:
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2403
Target Ref:
refs/pending/branch-heads/2403
Project:
chromium
Visibility:
Public.

Description

Fixed Chrome OS password changing dialog. The dialog was broken because of race condition between https://codereview.chromium.org/1115993002 and https://codereview.chromium.org/1129063003 BUG=488629 TEST=manually Review URL: https://codereview.chromium.org/1124213004 Cr-Commit-Position: refs/heads/master@{#330237} (cherry picked from commit d1b5d559c63656bb344519d18e4e995fd6a8e9f9) Committed: https://chromium.googlesource.com/chromium/src/+/d96629ccd58947a0e61dcee38e8688322c98784d

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+13 lines, -12 lines)
M chrome/browser/resources/chromeos/login/gaia_password_changed.html View 1 chunk +6 lines, -5 lines 0 comments
M chrome/browser/resources/chromeos/login/gaia_password_changed.js View 4 chunks +7 lines, -7 lines 0 comments

Messages

Total messages: 1 (0 generated)
dzhioev (left Google)
5 years, 7 months ago (2015-05-18 21:21:33 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d96629ccd58947a0e61dcee38e8688322c98784d.

Powered by Google App Engine