Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1129063003: <gaia-input> element extracted from <gaia-input-form>. (Closed)

Created:
5 years, 7 months ago by dzhioev (left Google)
Modified:
5 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<gaia-input> element extracted from <gaia-input-form>. I extracted HTML, JS, CSS code of input field from <gaia-input-form> to a standalone element <gaia-input>, to be able to use it independently. In addition, made possible to put several <gaia-inputs> into a single input form. That is needed for enrollment Asset ID UI. BUG=470374 TEST=manually, offline GAIA works Committed: https://crrev.com/cd3803fad24e1868065435d712af55641b165be8 Cr-Commit-Position: refs/heads/master@{#328934}

Patch Set 1 #

Total comments: 14

Patch Set 2 : Comments. #

Patch Set 3 : Corrected test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -142 lines) Patch
M chrome/browser/chromeos/login/login_browsertest.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/custom_elements_login.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/custom_elements_login.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/custom_elements_oobe.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/custom_elements_oobe.js View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/gaia_input.css View 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/gaia_input.html View 1 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/login/gaia_input.js View 1 chunk +59 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_input_form.css View 1 chunk +3 lines, -28 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_input_form.html View 1 chunk +10 lines, -23 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_input_form.js View 1 chunk +2 lines, -46 lines 0 comments Download
M chrome/browser/resources/chromeos/login/offline_gaia.html View 1 2 chunks +14 lines, -10 lines 0 comments Download
M chrome/browser/resources/chromeos/login/offline_gaia.js View 1 4 chunks +25 lines, -31 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
dzhioev (left Google)
Nikita, PTAL
5 years, 7 months ago (2015-05-07 06:53:27 UTC) #2
Nikita (slow)
lgtm https://codereview.chromium.org/1129063003/diff/1/chrome/browser/resources/chromeos/login/gaia_input.html File chrome/browser/resources/chromeos/login/gaia_input.html (right): https://codereview.chromium.org/1129063003/diff/1/chrome/browser/resources/chromeos/login/gaia_input.html#newcode7 chrome/browser/resources/chromeos/login/gaia_input.html:7: Material desing input field, that supports different input ...
5 years, 7 months ago (2015-05-07 09:44:13 UTC) #3
dzhioev (left Google)
https://codereview.chromium.org/1129063003/diff/1/chrome/browser/resources/chromeos/login/gaia_input.html File chrome/browser/resources/chromeos/login/gaia_input.html (right): https://codereview.chromium.org/1129063003/diff/1/chrome/browser/resources/chromeos/login/gaia_input.html#newcode7 chrome/browser/resources/chromeos/login/gaia_input.html:7: Material desing input field, that supports different input types ...
5 years, 7 months ago (2015-05-07 22:21:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129063003/20001
5 years, 7 months ago (2015-05-07 22:23:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/15574)
5 years, 7 months ago (2015-05-07 23:32:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129063003/40001
5 years, 7 months ago (2015-05-08 05:58:39 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-08 06:40:07 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 06:40:56 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cd3803fad24e1868065435d712af55641b165be8
Cr-Commit-Position: refs/heads/master@{#328934}

Powered by Google App Engine
This is Rietveld 408576698