Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 1124213004: Fixed Chrome OS password changing dialog. (Closed)

Created:
5 years, 7 months ago by dzhioev (left Google)
Modified:
5 years, 7 months ago
Reviewers:
achuithb
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed Chrome OS password changing dialog. The dialog was broken because of race condition between https://codereview.chromium.org/1115993002 and https://codereview.chromium.org/1129063003 BUG=488629 TEST=manually Committed: https://crrev.com/d1b5d559c63656bb344519d18e4e995fd6a8e9f9 Cr-Commit-Position: refs/heads/master@{#330237}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/browser/resources/chromeos/login/gaia_password_changed.html View 1 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/login/gaia_password_changed.js View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dzhioev (left Google)
5 years, 7 months ago (2015-05-15 22:17:50 UTC) #2
achuithb
lgtm
5 years, 7 months ago (2015-05-15 22:19:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124213004/20001
5 years, 7 months ago (2015-05-15 22:24:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 23:52:07 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:29:24 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d1b5d559c63656bb344519d18e4e995fd6a8e9f9
Cr-Commit-Position: refs/heads/master@{#330237}

Powered by Google App Engine
This is Rietveld 408576698