Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128153007: Disable TabindexOpenDialog_FileManagerBrowserTest tests on official build. (Closed)

Created:
5 years, 7 months ago by xdai1
Modified:
5 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable TabindexOpenDialog_FileManagerBrowserTest tests on official build. This test has been failing on cros trunk builder for several days. BUG=480491 Committed: https://crrev.com/90b9341734f1606b23a32675177de7f2e2f4d5ea Cr-Commit-Position: refs/heads/master@{#330630}

Patch Set 1 #

Patch Set 2 : Disable the test only on official build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
xdai1
Oshima, could you help to review the CL please? This CL just disables a browser ...
5 years, 7 months ago (2015-05-19 21:07:52 UTC) #2
oshima
can you disable only on release build?
5 years, 7 months ago (2015-05-19 21:21:42 UTC) #3
xdai1
On 2015/05/19 21:21:42, oshima wrote: > can you disable only on release build? Addressed! Please ...
5 years, 7 months ago (2015-05-19 21:31:31 UTC) #5
oshima
lgtm thanks!
5 years, 7 months ago (2015-05-19 21:32:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128153007/40001
5 years, 7 months ago (2015-05-19 22:05:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-19 22:12:01 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:13:27 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/90b9341734f1606b23a32675177de7f2e2f4d5ea
Cr-Commit-Position: refs/heads/master@{#330630}

Powered by Google App Engine
This is Rietveld 408576698