chrome/browser/chromeos/file_manager/file_manager_browsertest.cc - Issue 1128153007: Disable TabindexOpenDialog_FileManagerBrowserTest tests on official build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 1128153007: Disable TabindexOpenDialog_FileManagerBrowserTest tests on official build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable the test only on official build Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

diff --git a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

index f4aab53c5719d2228332d718442e774c5cc33c87..987ffd17fffe251602212b35869eaa81a8a66798 100644

--- a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

+++ b/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

@@ -1132,8 +1132,14 @@ WRAPPED_INSTANTIATE_TEST_CASE_P(

::testing::Values(TestParameter(NOT_IN_GUEST_MODE,

"tabindexFocusDirectorySelected")));

+// Fails on official cros trunk build. http://crbug.com/480491

+#if defined(OFFICIAL_BUILD)

+#define MAYBE_TabindexOpenDialog DISABLED_TabindexOpenDialog

+#else

+#define MAYBE_TabindexOpenDialog TabindexOpenDialog

+#endif

INSTANTIATE_TEST_CASE_P(

- TabindexOpenDialog,

+ MAYBE_TabindexOpenDialog,

FileManagerBrowserTest,

::testing::Values(

TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDrive"),

« no previous file with comments | « no previous file | no next file » | no next file with comments »