Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 1128153007: Disable TabindexOpenDialog_FileManagerBrowserTest tests on official build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable the test only on official build Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Browser test for basic Chrome OS file manager functionality: 5 // Browser test for basic Chrome OS file manager functionality:
6 // - The file list is updated when a file is added externally to the Downloads 6 // - The file list is updated when a file is added externally to the Downloads
7 // folder. 7 // folder.
8 // - Selecting a file and copy-pasting it with the keyboard copies the file. 8 // - Selecting a file and copy-pasting it with the keyboard copies the file.
9 // - Selecting a file and pressing delete deletes it. 9 // - Selecting a file and pressing delete deletes it.
10 10
(...skipping 1114 matching lines...) Expand 10 before | Expand all | Expand 10 after
1125 DISABLED_TabindexFocusDirectorySelected 1125 DISABLED_TabindexFocusDirectorySelected
1126 #else 1126 #else
1127 #define MAYBE_TabindexFocusDirectorySelected TabindexFocusDirectorySelected 1127 #define MAYBE_TabindexFocusDirectorySelected TabindexFocusDirectorySelected
1128 #endif 1128 #endif
1129 WRAPPED_INSTANTIATE_TEST_CASE_P( 1129 WRAPPED_INSTANTIATE_TEST_CASE_P(
1130 MAYBE_TabindexFocusDirectorySelected, 1130 MAYBE_TabindexFocusDirectorySelected,
1131 FileManagerBrowserTest, 1131 FileManagerBrowserTest,
1132 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, 1132 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
1133 "tabindexFocusDirectorySelected"))); 1133 "tabindexFocusDirectorySelected")));
1134 1134
1135 // Fails on official cros trunk build. http://crbug.com/480491
1136 #if defined(OFFICIAL_BUILD)
1137 #define MAYBE_TabindexOpenDialog DISABLED_TabindexOpenDialog
1138 #else
1139 #define MAYBE_TabindexOpenDialog TabindexOpenDialog
1140 #endif
1135 INSTANTIATE_TEST_CASE_P( 1141 INSTANTIATE_TEST_CASE_P(
1136 TabindexOpenDialog, 1142 MAYBE_TabindexOpenDialog,
1137 FileManagerBrowserTest, 1143 FileManagerBrowserTest,
1138 ::testing::Values( 1144 ::testing::Values(
1139 TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDrive"), 1145 TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDrive"),
1140 TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDownloads"), 1146 TestParameter(NOT_IN_GUEST_MODE, "tabindexOpenDialogDownloads"),
1141 TestParameter(IN_GUEST_MODE, "tabindexOpenDialogDownloads"))); 1147 TestParameter(IN_GUEST_MODE, "tabindexOpenDialogDownloads")));
1142 1148
1143 // Fails on official build. http://crbug.com/482121. 1149 // Fails on official build. http://crbug.com/482121.
1144 #if defined(OFFICIAL_BUILD) 1150 #if defined(OFFICIAL_BUILD)
1145 #define MAYBE_TabindexSaveFileDialog DISABLED_TabindexSaveFileDialog 1151 #define MAYBE_TabindexSaveFileDialog DISABLED_TabindexSaveFileDialog
1146 #else 1152 #else
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
1540 StartTest(); 1546 StartTest();
1541 } 1547 }
1542 1548
1543 IN_PROC_BROWSER_TEST_F(VideoPlayerBrowserTest, OpenSingleVideoOnDrive) { 1549 IN_PROC_BROWSER_TEST_F(VideoPlayerBrowserTest, OpenSingleVideoOnDrive) {
1544 set_test_case_name("openSingleVideoOnDrive"); 1550 set_test_case_name("openSingleVideoOnDrive");
1545 StartTest(); 1551 StartTest();
1546 } 1552 }
1547 1553
1548 } // namespace 1554 } // namespace
1549 } // namespace file_manager 1555 } // namespace file_manager
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698