Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1128153002: Rename the devtools library: pylib -> devtoolslib. (Closed)

Created:
5 years, 7 months ago by ppi
Modified:
5 years, 7 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename the devtools library: pylib -> devtoolslib. Too many pylibs everywhere - this patch allows to avoid conflicts when devtools consumer wants to build their wrapper over devtools library, but they already have their own unicorn called pylib. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1d702b06c10e809b352ebe3587510319cd9daafd

Patch Set 1 #

Patch Set 2 : Address offline comments/ devtools_lib -> devtoolslib. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -851 lines) Patch
A + mojo/devtools/common/devtoolslib/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/devtools/common/devtoolslib/android_shell.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/devtools/common/devtoolslib/apptest.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/devtools/common/devtoolslib/apptest_dart.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + mojo/devtools/common/devtoolslib/apptest_gtest.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + mojo/devtools/common/devtoolslib/apptest_gtest_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + mojo/devtools/common/devtoolslib/http_server.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/devtools/common/devtoolslib/linux_shell.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + mojo/devtools/common/devtoolslib/shell.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/devtools/common/pylib/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/devtools/common/pylib/android_shell.py View 1 chunk +0 lines, -333 lines 0 comments Download
D mojo/devtools/common/pylib/apptest.py View 1 chunk +0 lines, -73 lines 0 comments Download
D mojo/devtools/common/pylib/apptest_dart.py View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/devtools/common/pylib/apptest_gtest.py View 1 chunk +0 lines, -119 lines 0 comments Download
D mojo/devtools/common/pylib/apptest_gtest_unittest.py View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/devtools/common/pylib/http_server.py View 1 chunk +0 lines, -140 lines 0 comments Download
D mojo/devtools/common/pylib/linux_shell.py View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/devtools/common/pylib/shell.py View 1 chunk +0 lines, -31 lines 0 comments Download
M mojo/tools/android_mojo_shell.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/tools/apptest_runner.py View 1 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/tools/devtools.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ppi
Hi Ben, ptal.
5 years, 7 months ago (2015-05-06 14:33:09 UTC) #1
ppi
Changed to devtoolslib as discussed offline, ptal.
5 years, 7 months ago (2015-05-06 14:48:37 UTC) #2
qsr
lgtm
5 years, 7 months ago (2015-05-06 14:48:57 UTC) #3
ppi
5 years, 7 months ago (2015-05-06 14:50:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
1d702b06c10e809b352ebe3587510319cd9daafd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698