Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: mojo/devtools/common/devtoolslib/linux_shell.py

Issue 1128153002: Rename the devtools library: pylib -> devtoolslib. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address offline comments/ devtools_lib -> devtoolslib. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import subprocess 5 import subprocess
6 6
7 from pylib.shell import Shell 7 from devtoolslib.shell import Shell
8 8
9 9
10 class LinuxShell(Shell): 10 class LinuxShell(Shell):
11 """Wrapper around Mojo shell running on Linux. 11 """Wrapper around Mojo shell running on Linux.
12 12
13 Args: 13 Args:
14 executable_path: path to the shell binary 14 executable_path: path to the shell binary
15 command_prefix: optional list of arguments to prepend to the shell command, 15 command_prefix: optional list of arguments to prepend to the shell command,
16 allowing e.g. to run the shell under debugger. 16 allowing e.g. to run the shell under debugger.
17 """ 17 """
(...skipping 22 matching lines...) Expand all
40 Returns: 40 Returns:
41 A tuple of (return_code, output). |return_code| is the exit code returned 41 A tuple of (return_code, output). |return_code| is the exit code returned
42 by the shell or None if the exit code cannot be retrieved. |output| is the 42 by the shell or None if the exit code cannot be retrieved. |output| is the
43 stdout mingled with the stderr produced by the shell. 43 stdout mingled with the stderr produced by the shell.
44 """ 44 """
45 command = self.command_prefix + [self.executable_path] + arguments 45 command = self.command_prefix + [self.executable_path] + arguments
46 p = subprocess.Popen(command, stdout=subprocess.PIPE, 46 p = subprocess.Popen(command, stdout=subprocess.PIPE,
47 stderr=subprocess.STDOUT) 47 stderr=subprocess.STDOUT)
48 (output, _) = p.communicate() 48 (output, _) = p.communicate()
49 return p.returncode, output 49 return p.returncode, output
OLDNEW
« no previous file with comments | « mojo/devtools/common/devtoolslib/http_server.py ('k') | mojo/devtools/common/devtoolslib/shell.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698