Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1563)

Unified Diff: mojo/devtools/common/pylib/apptest_dart.py

Issue 1128153002: Rename the devtools library: pylib -> devtoolslib. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address offline comments/ devtools_lib -> devtoolslib. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/devtools/common/pylib/apptest.py ('k') | mojo/devtools/common/pylib/apptest_gtest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/pylib/apptest_dart.py
diff --git a/mojo/devtools/common/pylib/apptest_dart.py b/mojo/devtools/common/pylib/apptest_dart.py
deleted file mode 100644
index 41fdb2bd0cc5a46f20a4dbe4d3d5eb6bda595d78..0000000000000000000000000000000000000000
--- a/mojo/devtools/common/pylib/apptest_dart.py
+++ /dev/null
@@ -1,40 +0,0 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""Apptest runner specific to the particular Dart apptest framework in
-/mojo/dart/apptests, built on top of the general apptest runner."""
-
-import logging
-
-_logging = logging.getLogger()
-
-from pylib.apptest import run_apptest
-
-
-def _dart_apptest_output_test(output):
- # Fail on output with dart unittests' "FAIL:"/"ERROR:" or a lack of "PASS:".
- # The latter condition ensures failure on broken command lines or output.
- # Check output instead of exit codes because mojo_shell always exits with 0.
- if (not output or
- '\nFAIL: ' in output or
- '\nERROR: ' in output or
- '\nPASS: ' not in output):
- return False
- return True
-
-
-# TODO(erg): Support android, launched services and fixture isolation.
-def run_dart_apptest(shell, shell_args, apptest_url, apptest_args):
- """Runs a dart apptest.
-
- Args:
- shell_args: The arguments for mojo_shell.
- apptest_url: Url of the apptest app to run.
- apptest_args: Parameters to be passed to the apptest app.
-
- Returns:
- True iff the test succeeded, False otherwise.
- """
- return run_apptest(shell, shell_args, apptest_url, apptest_args,
- _dart_apptest_output_test)
« no previous file with comments | « mojo/devtools/common/pylib/apptest.py ('k') | mojo/devtools/common/pylib/apptest_gtest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698