Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1128043007: Support Kerberos on Android (Closed)

Created:
5 years, 7 months ago by aberent
Modified:
5 years, 4 months ago
CC:
asvitkine+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, Ryan Sleevi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support Kerberos on Android As part of this, allow asynchronous token return. This should be allowed anyway, but is particularly important on Android, where getting a token may cause user interaction. BUG=474943 Committed: https://crrev.com/ec894a5d76eadbe3cb489faed6469ff78e00aec8 Cr-Commit-Position: refs/heads/master@{#338039}

Patch Set 1 #

Total comments: 17

Patch Set 2 : Fix build problems found by bots #

Patch Set 3 : Fix more problems found by bots #

Patch Set 4 : Fix Windows builds and one more Android test #

Patch Set 5 : Fix mistake in previous Windows fixes #

Total comments: 10

Patch Set 6 : Changes for bauerb@'s comments, plus some other minor fixes. #

Total comments: 8

Patch Set 7 : Fix more nits from bauerb@ #

Total comments: 2

Patch Set 8 : Add Junit tests for Java class #

Patch Set 9 : Various minor fixes. #

Patch Set 10 : Add some unit tests, separate out new policy into a new CL (TBA). #

Patch Set 11 : Add parser tests, remove unused changes #

Patch Set 12 : Move histograms.xml to policy patch, rebase, minor logging fixes. #

Patch Set 13 : Fix a nit I had missed. #

Total comments: 60

Patch Set 14 : Handle review comments #

Total comments: 42

Patch Set 15 : Intermediate upload to fix problems with tests and with refactoring of parsing. #

Patch Set 16 : Deal with comments and build and test failures. #

Total comments: 4

Patch Set 17 : Respond to jbudorick@ and fix build and test problems #

Patch Set 18 : Fix Windows Negotiate parsing #

Patch Set 19 : Add tests for new parser #

Patch Set 20 : Fix tests and error handling #

Patch Set 21 : Fix compile (clang) issues. #

Patch Set 22 : Fix remaining clang issue (missing override). #

Patch Set 23 : Fix Android GN build #

Total comments: 122

Patch Set 24 : Many fixes in response to comments, including more work on tests #

Patch Set 25 : Remove possibly confusing "auto"s. Add comments on callback_wrapper lifetime. #

Patch Set 26 : Fix compile errors caused by trying to forward declare a typedef #

Total comments: 8

Patch Set 27 : Pure rebase - no other changes #

Patch Set 28 : Pure rebase -- attempt 2 #

Patch Set 29 : Fix cbentzel@'s nits #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1867 lines, -200 lines) Patch
M build/android/pylib/gtest/test_package_apk.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +7 lines, -1 line 1 comment Download
M chrome/browser/io_thread.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +5 lines, -0 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +3 lines, -8 lines 0 comments Download
M net/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 3 chunks +10 lines, -2 lines 0 comments Download
M net/android/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +12 lines, -0 lines 0 comments Download
A net/android/dummy_spnego_authenticator.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 1 chunk +140 lines, -0 lines 0 comments Download
A net/android/dummy_spnego_authenticator.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +204 lines, -0 lines 0 comments Download
A net/android/http_auth_negotiate_android.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +132 lines, -0 lines 0 comments Download
A net/android/http_auth_negotiate_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +154 lines, -0 lines 0 comments Download
A net/android/http_auth_negotiate_android_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +94 lines, -0 lines 0 comments Download
A net/android/java/src/org/chromium/net/HttpNegotiateAuthenticator.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +139 lines, -0 lines 0 comments Download
A net/android/java/src/org/chromium/net/HttpNegotiateConstants.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +51 lines, -0 lines 0 comments Download
A net/android/junit/src/org/chromium/net/HttpNegotiateAuthenticatorTest.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +222 lines, -0 lines 0 comments Download
M net/android/net_jni_registrar.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +2 lines, -0 lines 0 comments Download
A + net/android/unittest_support/AndroidManifest.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +12 lines, -0 lines 0 comments Download
A net/android/unittest_support/res/mipmap-hdpi/app_icon.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 Binary file 0 comments Download
A net/android/unittest_support/res/mipmap-mdpi/app_icon.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 Binary file 0 comments Download
A net/android/unittest_support/res/mipmap-xhdpi/app_icon.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 Binary file 0 comments Download
A net/android/unittest_support/res/mipmap-xxhdpi/app_icon.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 Binary file 0 comments Download
A net/android/unittest_support/res/mipmap-xxxhdpi/app_icon.png View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 Binary file 0 comments Download
A net/android/unittest_support/res/xml/dummy_spnego_account_preferences.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
A net/android/unittest_support/res/xml/dummy_spnego_authenticator.xml View 1 2 3 4 5 6 7 8 9 1 chunk +8 lines, -0 lines 0 comments Download
M net/http/http_auth_gssapi_posix.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 24 25 3 chunks +21 lines, -4 lines 0 comments Download
M net/http/http_auth_gssapi_posix.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +8 lines, -29 lines 0 comments Download
M net/http/http_auth_gssapi_posix_unittest.cc View 14 4 chunks +12 lines, -3 lines 0 comments Download
M net/http/http_auth_handler_factory.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +7 lines, -1 line 0 comments Download
M net/http/http_auth_handler_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 4 chunks +8 lines, -3 lines 0 comments Download
M net/http/http_auth_handler_factory_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +3 lines, -2 lines 0 comments Download
M net/http/http_auth_handler_negotiate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 4 chunks +12 lines, -5 lines 0 comments Download
M net/http/http_auth_handler_negotiate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 4 chunks +16 lines, -8 lines 0 comments Download
M net/http/http_auth_handler_negotiate_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 10 chunks +50 lines, -32 lines 0 comments Download
M net/http/http_auth_handler_ntlm.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -4 lines 0 comments Download
A net/http/http_auth_multi_round_parse.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +29 lines, -0 lines 0 comments Download
A net/http/http_auth_multi_round_parse.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +58 lines, -0 lines 0 comments Download
A net/http/http_auth_multi_round_parse_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +78 lines, -0 lines 0 comments Download
M net/http/http_auth_sspi_win.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 24 25 2 chunks +26 lines, -8 lines 0 comments Download
M net/http/http_auth_sspi_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +8 lines, -27 lines 0 comments Download
M net/http/http_auth_sspi_win_unittest.cc View 1 2 3 14 4 chunks +12 lines, -3 lines 0 comments Download
M net/http/http_auth_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +48 lines, -49 lines 0 comments Download
M net/net.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 8 chunks +38 lines, -5 lines 0 comments Download
M net/net.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 4 chunks +8 lines, -0 lines 0 comments Download
M net/net_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +2 lines, -0 lines 0 comments Download
A net/test/android/javatests/src/org/chromium/net/test/DummySpnegoAuthenticator.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +186 lines, -0 lines 0 comments Download
A net/test/android/javatests/src/org/chromium/net/test/DummySpnegoAuthenticatorService.java View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +22 lines, -0 lines 0 comments Download
M net/test/run_all_unittests.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 133 (54 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/1
5 years, 7 months ago (2015-05-13 17:12:20 UTC) #2
aberent
On 2015/05/13 at 17:12:38, aberent wrote: > aberent@chromium.org changed reviewers: > + bauerb@chromium.org Preliminary version, ...
5 years, 7 months ago (2015-05-13 17:13:40 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/37231) linux_chromium_gn_dbg on ...
5 years, 7 months ago (2015-05-13 17:27:43 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/20001
5 years, 7 months ago (2015-05-14 12:08:33 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/72033)
5 years, 7 months ago (2015-05-14 12:18:46 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/40001
5 years, 7 months ago (2015-05-14 17:55:12 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/83903)
5 years, 7 months ago (2015-05-14 18:36:20 UTC) #14
Bernhard Bauer
On 2015/05/13 17:13:40, aberent wrote: > On 2015/05/13 at 17:12:38, aberent wrote: > > mailto:aberent@chromium.org ...
5 years, 7 months ago (2015-05-15 00:15:46 UTC) #15
aberent
On 2015/05/15 at 00:15:46, bauerb wrote: > On 2015/05/13 17:13:40, aberent wrote: > > On ...
5 years, 7 months ago (2015-05-15 08:42:54 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/60001
5 years, 7 months ago (2015-05-15 10:45:48 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/80001
5 years, 7 months ago (2015-05-15 11:13:39 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 12:56:23 UTC) #23
Bernhard Bauer
https://codereview.chromium.org/1128043007/diff/1/net/android/http_android_auth_negotiate.cc File net/android/http_android_auth_negotiate.cc (right): https://codereview.chromium.org/1128043007/diff/1/net/android/http_android_auth_negotiate.cc#newcode13 net/android/http_android_auth_negotiate.cc:13: #include "jni/HttpNegotiateAuthenticator_jni.h" The generated JNI include usually goes at ...
5 years, 7 months ago (2015-05-15 15:06:16 UTC) #24
aberent
https://codereview.chromium.org/1128043007/diff/1/net/android/http_android_auth_negotiate.cc File net/android/http_android_auth_negotiate.cc (right): https://codereview.chromium.org/1128043007/diff/1/net/android/http_android_auth_negotiate.cc#newcode13 net/android/http_android_auth_negotiate.cc:13: #include "jni/HttpNegotiateAuthenticator_jni.h" On 2015/05/15 15:06:16, Bernhard Bauer wrote: > ...
5 years, 7 months ago (2015-05-18 13:45:28 UTC) #25
Bernhard Bauer
https://codereview.chromium.org/1128043007/diff/1/net/android/http_android_auth_negotiate.cc File net/android/http_android_auth_negotiate.cc (right): https://codereview.chromium.org/1128043007/diff/1/net/android/http_android_auth_negotiate.cc#newcode13 net/android/http_android_auth_negotiate.cc:13: #include "jni/HttpNegotiateAuthenticator_jni.h" On 2015/05/18 13:45:27, aberent wrote: > On ...
5 years, 7 months ago (2015-05-18 15:11:54 UTC) #26
aberent
https://codereview.chromium.org/1128043007/diff/1/net/android/http_android_auth_negotiate.cc File net/android/http_android_auth_negotiate.cc (right): https://codereview.chromium.org/1128043007/diff/1/net/android/http_android_auth_negotiate.cc#newcode13 net/android/http_android_auth_negotiate.cc:13: #include "jni/HttpNegotiateAuthenticator_jni.h" On 2015/05/18 at 15:11:53, Bernhard Bauer wrote: ...
5 years, 7 months ago (2015-05-18 17:07:31 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/120001
5 years, 7 months ago (2015-05-20 09:17:58 UTC) #29
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-20 10:19:32 UTC) #31
Bernhard Bauer
https://codereview.chromium.org/1128043007/diff/80001/net/android/http_android_auth_negotiate.h File net/android/http_android_auth_negotiate.h (right): https://codereview.chromium.org/1128043007/diff/80001/net/android/http_android_auth_negotiate.h#newcode13 net/android/http_android_auth_negotiate.h:13: Remove empty line? https://codereview.chromium.org/1128043007/diff/80001/net/android/http_android_auth_negotiate.h#newcode40 net/android/http_android_auth_negotiate.h:40: // The function may ...
5 years, 6 months ago (2015-06-01 14:51:13 UTC) #32
aberent
https://codereview.chromium.org/1128043007/diff/80001/net/android/http_android_auth_negotiate.h File net/android/http_android_auth_negotiate.h (right): https://codereview.chromium.org/1128043007/diff/80001/net/android/http_android_auth_negotiate.h#newcode13 net/android/http_android_auth_negotiate.h:13: On 2015/06/01 14:51:13, Bernhard Bauer wrote: > Remove empty ...
5 years, 6 months ago (2015-06-10 15:48:56 UTC) #33
aberent
cbentzel@chromium.org: Please review all, but in particular changes in net. zea@chromium.org: Please review change in ...
5 years, 6 months ago (2015-06-10 16:17:04 UTC) #35
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/240001
5 years, 6 months ago (2015-06-10 16:26:33 UTC) #37
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/85395)
5 years, 6 months ago (2015-06-10 16:43:44 UTC) #39
Bernhard Bauer
+Ryan FYI https://codereview.chromium.org/1128043007/diff/240001/chrome/common/pref_names.cc File chrome/common/pref_names.cc (right): https://codereview.chromium.org/1128043007/diff/240001/chrome/common/pref_names.cc#newcode1711 chrome/common/pref_names.cc:1711: // String that specifies the name of ...
5 years, 6 months ago (2015-06-10 17:11:03 UTC) #40
Nicolas Zea
mcs probe LGTM
5 years, 6 months ago (2015-06-10 18:42:36 UTC) #41
cbentzel
On 2015/06/10 18:42:36, Nicolas Zea wrote: > mcs probe LGTM I'll take a look at ...
5 years, 6 months ago (2015-06-11 02:54:08 UTC) #42
cbentzel
On 2015/06/10 18:42:36, Nicolas Zea wrote: > mcs probe LGTM I'll take a look at ...
5 years, 6 months ago (2015-06-11 02:54:12 UTC) #43
cbentzel
On 2015/06/11 02:54:12, cbentzel wrote: > On 2015/06/10 18:42:36, Nicolas Zea wrote: > > mcs ...
5 years, 6 months ago (2015-06-11 03:39:25 UTC) #44
cbentzel
On 2015/06/11 03:39:25, cbentzel wrote: > On 2015/06/11 02:54:12, cbentzel wrote: > > On 2015/06/10 ...
5 years, 6 months ago (2015-06-11 15:41:50 UTC) #45
aberent
On 2015/06/11 15:41:50, cbentzel wrote: > On 2015/06/11 03:39:25, cbentzel wrote: > > On 2015/06/11 ...
5 years, 6 months ago (2015-06-11 18:10:23 UTC) #46
cbentzel
On 2015/06/11 18:10:23, aberent wrote: > On 2015/06/11 15:41:50, cbentzel wrote: > > On 2015/06/11 ...
5 years, 6 months ago (2015-06-11 20:32:36 UTC) #47
cbentzel
Overall structure looks good. I have not taken a pass over unit tests yet. Could ...
5 years, 6 months ago (2015-06-11 20:51:44 UTC) #48
aberent
https://codereview.chromium.org/1128043007/diff/240001/chrome/common/pref_names.cc File chrome/common/pref_names.cc (right): https://codereview.chromium.org/1128043007/diff/240001/chrome/common/pref_names.cc#newcode1711 chrome/common/pref_names.cc:1711: // String that specifies the name of Android account ...
5 years, 6 months ago (2015-06-15 15:52:20 UTC) #49
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/260001
5 years, 6 months ago (2015-06-15 15:53:47 UTC) #52
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/82113)
5 years, 6 months ago (2015-06-15 16:07:14 UTC) #54
aberent
On 2015/06/11 20:51:44, cbentzel wrote: > Overall structure looks good. I have not taken a ...
5 years, 6 months ago (2015-06-15 16:15:24 UTC) #55
Bernhard Bauer
https://codereview.chromium.org/1128043007/diff/260001/net/http/http_auth_handler_negotiate.cc File net/http/http_auth_handler_negotiate.cc (right): https://codereview.chromium.org/1128043007/diff/260001/net/http/http_auth_handler_negotiate.cc#newcode91 net/http/http_auth_handler_negotiate.cc:91: // TODO(ahendrickHson): Move towards model of parsing in the ...
5 years, 6 months ago (2015-06-15 16:43:11 UTC) #56
aberent
https://codereview.chromium.org/1128043007/diff/240001/net/android/http_android_auth_negotiate.cc File net/android/http_android_auth_negotiate.cc (right): https://codereview.chromium.org/1128043007/diff/240001/net/android/http_android_auth_negotiate.cc#newcode60 net/android/http_android_auth_negotiate.cc:60: // Verify the challenge's auth-scheme. On 2015/06/15 15:52:19, aberent ...
5 years, 6 months ago (2015-06-15 16:57:47 UTC) #57
cbentzel
On 2015/06/15 16:15:24, aberent wrote: > On 2015/06/11 20:51:44, cbentzel wrote: > > Overall structure ...
5 years, 6 months ago (2015-06-15 22:18:02 UTC) #58
Ryan Sleevi
https://codereview.chromium.org/1128043007/diff/260001/net/android/http_auth_negotiate_android.cc File net/android/http_auth_negotiate_android.cc (right): https://codereview.chromium.org/1128043007/diff/260001/net/android/http_auth_negotiate_android.cc#newcode65 net/android/http_auth_negotiate_android.cc:65: auth_token_ = auth_token; nit: a newline between 64 & ...
5 years, 6 months ago (2015-06-16 01:07:47 UTC) #60
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/280001
5 years, 6 months ago (2015-06-18 16:00:59 UTC) #63
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/83568) linux_chromium_gn_rel on ...
5 years, 6 months ago (2015-06-18 16:17:15 UTC) #65
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/300001
5 years, 6 months ago (2015-06-19 15:03:06 UTC) #68
aberent
jbudorick@chromium.org: Please review changes in build/android/pylib Other reviewers PTAL. Note that I have moved the ...
5 years, 6 months ago (2015-06-19 15:06:25 UTC) #70
jbudorick
Please add similar logic here: https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pylib/gtest/gtest_test_instance.py&l=153 https://codereview.chromium.org/1128043007/diff/300001/build/android/pylib/gtest/test_package_apk.py File build/android/pylib/gtest/test_package_apk.py (right): https://codereview.chromium.org/1128043007/diff/300001/build/android/pylib/gtest/test_package_apk.py#newcode39 build/android/pylib/gtest/test_package_apk.py:39: if suite_name == ...
5 years, 6 months ago (2015-06-19 15:15:19 UTC) #71
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/83373)
5 years, 6 months ago (2015-06-19 15:15:38 UTC) #73
aberent
https://codereview.chromium.org/1128043007/diff/300001/build/android/pylib/gtest/test_package_apk.py File build/android/pylib/gtest/test_package_apk.py (right): https://codereview.chromium.org/1128043007/diff/300001/build/android/pylib/gtest/test_package_apk.py#newcode39 build/android/pylib/gtest/test_package_apk.py:39: if suite_name == 'content_browsertests': On 2015/06/19 15:15:19, jbudorick wrote: ...
5 years, 6 months ago (2015-06-19 17:59:40 UTC) #74
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/320001
5 years, 6 months ago (2015-06-19 18:01:32 UTC) #77
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/71812) win_chromium_x64_rel_ng on ...
5 years, 6 months ago (2015-06-19 20:11:06 UTC) #79
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/340001
5 years, 6 months ago (2015-06-22 09:26:09 UTC) #82
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/36357)
5 years, 6 months ago (2015-06-22 09:58:54 UTC) #84
aberent
Now complete, please comment and/or LGTM.
5 years, 6 months ago (2015-06-24 15:48:50 UTC) #85
jbudorick
On 2015/06/19 at 15:15:19, jbudorick wrote: > Please add similar logic here: https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pylib/gtest/gtest_test_instance.py&l=153 ^ > ...
5 years, 6 months ago (2015-06-24 15:50:10 UTC) #88
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/380001
5 years, 6 months ago (2015-06-24 15:50:20 UTC) #89
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/90177)
5 years, 6 months ago (2015-06-24 16:48:21 UTC) #91
jbudorick
On 2015/06/24 at 15:50:10, jbudorick wrote: > On 2015/06/19 at 15:15:19, jbudorick wrote: > > ...
5 years, 6 months ago (2015-06-24 18:19:22 UTC) #92
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/400001
5 years, 6 months ago (2015-06-24 18:32:03 UTC) #95
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 6 months ago (2015-06-24 19:11:56 UTC) #97
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/420001
5 years, 6 months ago (2015-06-25 13:32:31 UTC) #100
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/102092)
5 years, 6 months ago (2015-06-25 13:48:46 UTC) #102
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/440001
5 years, 6 months ago (2015-06-25 14:17:59 UTC) #105
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-25 15:29:30 UTC) #107
Ryan Sleevi
https://codereview.chromium.org/1128043007/diff/440001/net/android/dummy_spnego_authenticator.cc File net/android/dummy_spnego_authenticator.cc (right): https://codereview.chromium.org/1128043007/diff/440001/net/android/dummy_spnego_authenticator.cc#newcode12 net/android/dummy_spnego_authenticator.cc:12: // iso.org.dod.internet.security.mechanism.snego (1.3.6.1.5.5.2) nit: Add a comment explaining where ...
5 years, 5 months ago (2015-06-29 13:56:46 UTC) #108
cbentzel
The biggest question for me is whether we can avoid GSSAPI knowledge in the DummySpnegoAuthenticator ...
5 years, 5 months ago (2015-06-30 12:53:56 UTC) #109
aberent
https://codereview.chromium.org/1128043007/diff/440001/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/1128043007/diff/440001/net/BUILD.gn#newcode1404 net/BUILD.gn:1404: # TODO(aberent) fix and enable these tests on Android. ...
5 years, 5 months ago (2015-07-02 21:13:37 UTC) #110
Ryan Sleevi
https://codereview.chromium.org/1128043007/diff/440001/net/android/http_auth_negotiate_android.cc File net/android/http_auth_negotiate_android.cc (right): https://codereview.chromium.org/1128043007/diff/440001/net/android/http_auth_negotiate_android.cc#newcode104 net/android/http_auth_negotiate_android.cc:104: auto callback_task_runner = base::ThreadTaskRunnerHandle::Get(); On 2015/07/02 21:13:34, aberent wrote: ...
5 years, 5 months ago (2015-07-02 23:51:47 UTC) #111
aberent
https://codereview.chromium.org/1128043007/diff/440001/net/android/http_auth_negotiate_android.cc File net/android/http_auth_negotiate_android.cc (right): https://codereview.chromium.org/1128043007/diff/440001/net/android/http_auth_negotiate_android.cc#newcode104 net/android/http_auth_negotiate_android.cc:104: auto callback_task_runner = base::ThreadTaskRunnerHandle::Get(); On 2015/07/02 23:51:47, Ryan Sleevi ...
5 years, 5 months ago (2015-07-03 10:43:49 UTC) #112
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/480001
5 years, 5 months ago (2015-07-03 10:44:41 UTC) #115
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/42190) (exceeded global ...
5 years, 5 months ago (2015-07-03 11:25:11 UTC) #117
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/500001
5 years, 5 months ago (2015-07-03 16:21:12 UTC) #120
aberent
https://codereview.chromium.org/1128043007/diff/440001/net/http/http_auth_gssapi_posix.h File net/http/http_auth_gssapi_posix.h (right): https://codereview.chromium.org/1128043007/diff/440001/net/http/http_auth_gssapi_posix.h#newcode12 net/http/http_auth_gssapi_posix.h:12: #include "net/base/completion_callback.h" On 2015/07/02 21:13:36, aberent wrote: > On ...
5 years, 5 months ago (2015-07-03 16:21:15 UTC) #121
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-03 17:36:20 UTC) #123
cbentzel
On 2015/07/03 17:36:20, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 5 months ago (2015-07-08 17:11:32 UTC) #124
cbentzel
LGTM! Please address the nits I list below, but you don't need to ping me ...
5 years, 5 months ago (2015-07-08 18:27:11 UTC) #125
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128043007/560001
5 years, 5 months ago (2015-07-09 13:38:16 UTC) #128
aberent
https://codereview.chromium.org/1128043007/diff/440001/net/http/http_auth_handler_negotiate.h File net/http/http_auth_handler_negotiate.h (right): https://codereview.chromium.org/1128043007/diff/440001/net/http/http_auth_handler_negotiate.h#newcode38 net/http/http_auth_handler_negotiate.h:38: typedef net::android::HttpAuthNegotiateAndroid AuthSystem; On 2015/07/08 18:27:11, cbentzel wrote: > ...
5 years, 5 months ago (2015-07-09 13:38:46 UTC) #129
commit-bot: I haz the power
Committed patchset #29 (id:560001)
5 years, 5 months ago (2015-07-09 14:46:04 UTC) #130
commit-bot: I haz the power
Patchset 29 (id:??) landed as https://crrev.com/ec894a5d76eadbe3cb489faed6469ff78e00aec8 Cr-Commit-Position: refs/heads/master@{#338039}
5 years, 5 months ago (2015-07-09 14:46:59 UTC) #131
Fabrice (no longer in Chrome)
5 years, 4 months ago (2015-07-31 13:20:29 UTC) #133
Message was sent while issue was closed.
https://codereview.chromium.org/1128043007/diff/560001/build/android/pylib/gt...
File build/android/pylib/gtest/test_package_apk.py (right):

https://codereview.chromium.org/1128043007/diff/560001/build/android/pylib/gt...
build/android/pylib/gtest/test_package_apk.py:47: self._extras =
{'RunInSubThread': ''}
This has been making the Android/asan bot fail since it landed.
Please, take a look at crbug.com/515881

Powered by Google App Engine
This is Rietveld 408576698