Support Kerberos on Android

net/http/http_auth_handler_factory.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_HTTP_HTTP_AUTH_HANDLER_FACTORY_H_
 #define NET_HTTP_HTTP_AUTH_HANDLER_FACTORY_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 160 matching lines @@
   // |gssapi_library_name| specifies the name of the GSSAPI library that will
   // be loaded on all platforms except Windows.
   //
   // |negotiate_disable_cname_lookup| and |negotiate_enable_port| both control
   // how Negotiate does SPN generation, by default these should be false.
   static HttpAuthHandlerRegistryFactory* Create(
       const std::vector<std::string>& supported_schemes,
       URLSecurityManager* security_manager,
       HostResolver* host_resolver,
       const std::string& gssapi_library_name,
+      const std::string& auth_android_negotiate_account_type,

[Ryan Sleevi, 2015/06/16 01:07:46]

This certainly feels like a layering smell - to expose Android-specific data
types in a platform-generic class. Then again, not unprecedented (e.g. line
171/172)

Certainly, it seems like it should be documented (line 173).

[aberent, 2015/06/19 15:06:24]

I don't see that it is very different from gssapi_library_name, which is Posix
specific, or, with a different meaning, Windows specific.

I did wonder about changing the gssapi_library_name to something more generic
instead, such as negotiate_provider_name, and using this for both the library
name on Posix and Windows and for the account name on Android, but this didn't
feel quite right.

I have updated the function documentation.

Note that the old comment on gssapi_library_name is wrong, it can be used on
Windows to set the name of the SPPI library.

       bool negotiate_disable_cname_lookup,
       bool negotiate_enable_port);
 
   // Creates an auth handler by dispatching out to the registered factories
   // based on the first token in |challenge|.
   int CreateAuthHandler(HttpAuthChallengeTokenizer* challenge,
                         HttpAuth::Target target,
                         const GURL& origin,
                         CreateReason reason,
                         int digest_nonce_count,
                         const BoundNetLog& net_log,
                         scoped_ptr<HttpAuthHandler>* handler) override;
 
  private:
   typedef std::map<std::string, HttpAuthHandlerFactory*> FactoryMap;
 
   FactoryMap factory_map_;
   DISALLOW_COPY_AND_ASSIGN(HttpAuthHandlerRegistryFactory);
 };
 
 }  // namespace net
 
 #endif  // NET_HTTP_HTTP_AUTH_HANDLER_FACTORY_H_